docs: update documentation to match current codebase#68
Merged
Conversation
- Add AudioConstants.swift, MeetingDetecting.swift, PermissionRow.swift, PowerAssertionDetector.swift to CLAUDE.md project structure - Remove deleted MuteDetector.swift from CLAUDE.md and architecture-macos.md - Add MicRestartPolicy.swift to tools/audiotap/Sources/ listing - Add new plan files (appstate-tests, repo-review, workflow integration tests) to docs/plans/ listing - Update Package.swift description to mention SnapshotTesting dependency - Update Conventions: protocol output language is now configurable via AppSettings.protocolLanguage (default German), not hardcoded - Update Architecture Notes: ProtocolProvider enum now has .none option; add protocolLanguage note; add MeetingDetecting protocol + PowerAssertionDetector - Fix architecture-macos.md: ProtocolGenerator.swift is shared utilities, not the CLI invoker; split out ClaudeCLIProtocolGenerator and OpenAIProtocolGenerator as separate table rows; add Provider Selection section in Protocol Generation - Update Testing Hooks: replace MuteDetector row with PowerAssertionDetector - Add PermissionRow.swift and AudioConstants.swift to architecture-macos.md tables https://claude.ai/code/session_01Vrp4inxdcSo3sFFqWpdD2C
github-actions
bot
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation was out of sync with the codebase after several recent feature additions. This PR updates
CLAUDE.mdanddocs/architecture-macos.mdto reflect the current state of the code.Changes
New source files added to project structure:
AudioConstants.swift— shared audio pipeline constants (target sample rate)MeetingDetecting.swift—MeetingDetectingprotocol +DetectedMeetingmodelPermissionRow.swift— permission status row UI componentPowerAssertionDetector.swift— IOKit power assertion–based meeting detectionMicRestartPolicy.swift(audiotap) — pure decision logic for mic engine restart on device changeRemoved stale entries:
MuteDetector.swift— file no longer exists in the codebaseProtocol generation updates (from
feat(app): add None LLM providerandfeat(app): make protocol output language configurable):ProtocolProviderenum now has.noneoption (transcript only, no LLM)AppSettings.protocolLanguagereplaces the hardcoded "German" convention noteOther fixes:
Package.swiftdescription now mentionsSnapshotTestingtest dependencydocs/plans/listingarchitecture-macos.md:ProtocolGenerator.swiftdescription corrected (it's shared utilities, not the CLI invoker);ClaudeCLIProtocolGenerator.swiftandOpenAIProtocolGenerator.swiftadded as separate table rowsMuteDetector / muteStateProviderrow withPowerAssertionDetector / assertionProvider + windowListProviderhttps://claude.ai/code/session_01Vrp4inxdcSo3sFFqWpdD2C