fix(build): use PlistBuddy for version injection#8
Merged
Conversation
Both run_app.sh and build_release.sh now use PlistBuddy to set CFBundleShortVersionString from the VERSION file. Replaces the fragile sed substitution that matched a hardcoded "0.1.0" placeholder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sedsubstitution (matching hardcoded0.1.0) withPlistBuddyinbuild_release.shVERSIONfile torun_app.sh(dev builds showed0.1.0instead of current version)Test plan
./scripts/run_app.sh— verify Settings → About shows correct version fromVERSIONfile./scripts/build_release.sh --no-notarize— verify release build has correct version