test(app): add minor view test gap coverage#88
Merged
Conversation
Verify granted overrides warning/optional flags, and warning takes priority over denied (xmark) in the icon selection logic. Extract iconNames(for:) helper to reduce boilerplate.
Verify animationFrame wraps safely via modulo for values exceeding frameCount, including large indices (999) for all animated badges.
Verify refresh button (arrow.clockwise icon) exists in the header.
pasrom
force-pushed
the
test/minor-view-test-gaps
branch
from
7879b59 to
4d83ebc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
Some AppPickerView gaps (list content, icon fallback) can't be tested with ViewInspector because
Listcontent depends on@Statepopulated inonAppear.formattedElapsedandjobColorin MenuBarView areprivate— identical logic in the publicformattedTime()is already tested. Not worth changing visibility.Test plan