fix(app): add KMeans crash recovery for FluidDiarizer#98
Merged
Conversation
Use flexible speaker range (min:1, max:n) instead of exact count to prevent KMeans crash when audio has fewer segments than requested speakers. Falls back to auto-detect mode if diarization still fails. Extract OfflineDiarizationProcessing protocol for the offline processing step. FluidOfflineProcessor is the production impl; MockOfflineProcessor enables testing retry logic without CoreML models. Inspired by @dagil-nvidia's fork.
pasrom
force-pushed
the
fix/diarizer-kmeans-crash-recovery
branch
from
7138893 to
b7e0513
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
min:1, max:n) instead of exact count to prevent KMeans crash when audio has fewer segments than requested speakersOfflineDiarizationProcessingprotocol for the offline processing step —FluidOfflineProcessoris the production impl,MockOfflineProcessorenables testing retry logic without CoreML modelsInspired by @dagil-nvidia's fork.
Test plan
testRetryWithAutoDetectOnFailure— first call fails, retry with auto-detect succeedstestNoRetryWithoutNumSpeakers— error propagates without retrytestNoRetryOnSuccess— no retry when first call succeedstestErrorPropagatesOnRetryFailure— error propagates when both attempts fail