Conversation
kleinjm
reviewed
Jul 20, 2021
Comment on lines
+256
to
+273
| all_params.append("async_req") | ||
| all_params.append("_return_http_data_only") | ||
| all_params.append("_preload_content") | ||
| all_params.append("_request_timeout") | ||
| all_params.append("mass_g") | ||
| all_params.append("total_price_cents_usd") | ||
| all_params.append("project_id") | ||
| all_params.append("metadata") | ||
| all_params.append("distance_m") | ||
| all_params.append("transportation_method") | ||
| all_params.append("package_mass_g") | ||
| all_params.append("create_order") | ||
| all_params.append("make") | ||
| all_params.append("model") | ||
| all_params.append("year") | ||
| all_params.append("transaction_value_btc_sats") | ||
| all_params.append("timestamp") | ||
| all_params.append("gas_used") |
Contributor
There was a problem hiding this comment.
seems like this list of params is defined for every request in this file and consist of all possible params rather than the ones needed just for this particular endpoint. Not a blocker but do you happen to know the reason for this?
Contributor
Author
There was a problem hiding this comment.
Yes, this is a limitation of the current template / code generation.
I'm adding a tracker here: https://app.asana.com/0/1200609773402056/1200634505135525/f
kleinjm
reviewed
Jul 20, 2021
| estimate.data.mass_g, 200 | ||
| ) # not setting an exact value since this is changing daily | ||
|
|
||
| def test_create_ethereum_estimate_transaction_value(self): |
Contributor
There was a problem hiding this comment.
Should there be tests for project_id,timestamp, and create_order params as well?
kleinjm
approved these changes
Jul 20, 2021
kleinjm
left a comment
kleinjm
left a comment
Contributor
There was a problem hiding this comment.
no blockers but we may want to beef up the tests to use the additional params
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
SDK Release Checklist