Generate Class#openapi_nullable methods#19
Merged
Merged
Conversation
bspellacy
requested changes
Jan 11, 2021
bspellacy
left a comment
Member
There was a problem hiding this comment.
This looks good - can we add a test for the methods that weren't working before to prevent this from happening again?
Member
|
Sorry - I should have been more clear! The specs you added look great, but it was my understanding that |
75116b2 to
231b723
Compare
Contributor
Author
|
Ah yes - makes more sense, thanks for clarifying! I took the opportunity to create some shared examples instead for the generated classes. Currently we only cover the |
bspellacy
approved these changes
Jan 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #5. Adding generated method
.openapi_nullableto modelsWhy
This method was removed ~9 months back and was breaking the
#to_hashmethod on the models.SDK Release Checklist