refactor: simplify lockfile parsers and core logic for maintainability#21
Open
mariojgt wants to merge 1 commit into
Open
refactor: simplify lockfile parsers and core logic for maintainability#21mariojgt wants to merge 1 commit into
mariojgt wants to merge 1 commit into
Conversation
Release 0.2.6 with several refactors and improvements: export isUuid from config and use it in the CLI (improves UUID validation and provisioning flow), introduce isSuccessStatus in client for clearer HTTP status checks, and refactor normalize.compare logic by extracting comparePartTokens and handling shorter segment ordering. Parsers: unify lockfile detection via LOCKFILE_SPECS (simpler probing and clearer error message), adjust npm lockfile name extraction to use forward slashes, add a small unquote() helper and apply it in pnpm and yarn parsers, and remove an unused path import. Public API changes: export NormalizeStats and return stats from scanAndReport. Misc: bumped package version to 0.2.6.
Contributor
Author
|
/review |
|
Well-structured refactor improves lockfile parsing modularity and simplifies core logic. 🎯 Quality: 85% Excellent · 📦 Size: Medium 📈 This month: Your 77th PR — above team average · Averaging Excellent |
devlob
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 0.2.6 with several refactors and improvements: export isUuid from config and use it in the CLI (improves UUID validation and provisioning flow), introduce isSuccessStatus in client for clearer HTTP status checks, and refactor normalize.compare logic by extracting comparePartTokens and handling shorter segment ordering. Parsers: unify lockfile detection via LOCKFILE_SPECS (simpler probing and clearer error message), adjust npm lockfile name extraction to use forward slashes, add a small unquote() helper and apply it in pnpm and yarn parsers, and remove an unused path import. Public API changes: export NormalizeStats and return stats from scanAndReport. Misc: bumped package version to 0.2.6.