some minor tweak, reuse the mirage-mtime.mock implementation#1
Merged
patricoferris merged 2 commits intopatricoferris:updating-miragefrom Aug 28, 2025
Merged
some minor tweak, reuse the mirage-mtime.mock implementation#1patricoferris merged 2 commits intopatricoferris:updating-miragefrom
patricoferris merged 2 commits intopatricoferris:updating-miragefrom
Conversation
Owner
|
Thanks @hannesm ! This seems sensible to me, shall I hold off until the reset function lands to merge this change in the PR ? |
Author
|
See ocaml/opam-repository#28392 -- once that is merged, it should be good (we may want to have a lower bound |
Author
|
And while at it, the 9p release ocaml/opam-repository#28394 and hvsock ocaml/opam-repository#28393 |
Author
|
I pushed a change with the bounds, this will only work once the above mentioned opam packages have been merged into the opam-repository. |
Author
|
Note the releases are merged in opam-repository now, so this should be fine to compile and being merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear @patricoferris (and maybe @djs55 is interested as well),
I fixed the issue at moby#646 (comment) by using the mirage-mtime.mock sublibrary.
This branch now compiles, what is needed though (pending releases I guess):
So, if you agree, I'd cut releases of these three opam packages in the mirage organization (after merging the mentioned outstanding PRs).