fix(identity): restack overlay onto latest fork/changes - #285
Closed
omegent-app[bot] wants to merge 13 commits into
Closed
fix(identity): restack overlay onto latest fork/changes#285omegent-app[bot] wants to merge 13 commits into
omegent-app[bot] wants to merge 13 commits into
Conversation
The classic mobile thread lists (phone Home and the iPad navigation sidebar) rendered settled threads with the same three-line chrome as active work — favicon, title, status pill, branch/server subtitle, PR badge, chevron — so the "Settled" shelf read as more inbox rather than history. Web has had a distinct slim settled row in both list modes (Sidebar.tsx settled shelf, SidebarV2 slim variant), and mobile's own Thread List v2 settled tail already ships one; only the classic mobile path was missing it. Settled rows now collapse to a single dimmed line — dimmed favicon, muted one-line title, draft dot, trailing settle time — in both the compact and sidebar variants, matching thread-list-v2-items.tsx. The row keeps its tap target (44pt), swipe actions, and long-press settle/unsettle menu. The trailing label uses the settle stamp when the server recorded one and falls back to last activity, so the shelf reads in the order it is sorted (resolveSettledRowTimestamp mirrors web's resolveSettledTimestamp). Settled rows lead with a favicon only where the row already carries project context (recency / flat / Needs attention); project-grouped lists already show one in the group header. Co-authored-by: omegent-app[bot] <306514130+omegent-app[bot]@users.noreply.github.com>
* feat(server): run blocking lifecycle scripts before worktree removal Add runOnWorktreeRemove and runOnPrMerged project script hooks so process and data reaping can finish before git worktree remove continues. Non-zero exit blocks removal. Also expose the flags in t3.json, scripts UI, and docs. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com> * fix(server): trigger runOnPrMerged on open→merged, not on remove Decouple PR-merge lifecycle from worktree removal. Fire runOnPrMerged when VCS remote status observes the same PR transition open→merged (once per cwd+PR). Worktree remove only runs runOnWorktreeRemove and waits for exit. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com> * feat(server): pass linked PR association env to lifecycle scripts Expose T3CODE_PR (URL preferred) plus number/url/title/base/head/state for the change request associated with the worktree branch. Populate on PR merge and on worktree remove when status knows the linked PR. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com> --------- Co-authored-by: omegent-app[bot] <306514130+omegent-app[bot]@users.noreply.github.com> Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
) Mine/Ours now keeps threads with no person tags (legacy, channel-only stamps like desktop, identity-disabled servers). Theirs is only threads that have person attribution excluding the session claim. Co-authored-by: omegent-app[bot] <306514130+omegent-app[bot]@users.noreply.github.com> Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
…pply Identity product reapply had dropped the mobile model-selection helper while new-task-flow still imported it, breaking mobile typecheck.
…#256) Remember Mine/Theirs across mobile restarts via device preferences, and let Mine/Theirs refine by created, participated, or both (default). Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
Created looked only at origin, so Theirs+Created included threads you joined (origin ≠ you) while Theirs+Both required you to be absent from every person tag — Created could show more than Both. Classify involvement first, then narrow by role so Both is always the superset. Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
Keep mobile-showcase landscape harness typing from fork/changes when rebasing the identity overlay; identity reapply had dropped the field.
Keep checkForAppUpdateOnLaunch wired after product-merging snooze actions into the identity HomeRouteScreen.
Production showcase deep links use t3code://; identity reapply left t3code-dev:// expectations that fail after restack compose.
Jira and GitHub treat an unset/empty identity map like an unmapped actor: no agent turns. Only mapped people may drive the host via those webhooks. Co-authored-by: omegent-app[bot] <306514130+omegent-app[bot]@users.noreply.github.com> Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
The header said claims were a process-local Ref with "Persistence later". `layerPersisted` has since made server claims SQLite-backed (SessionIdentityClaimRepository + migration 037), with the Ref demoted to a read-through cache. Only the residual-free `layer` used by the CLI and tests is still memory-only. Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
The server read T3_IDENTITY_MAP_PATH once at layer construction, so adding or removing a person meant restarting t3code-server. The map is now re-checked on a 60s TTL and applies in place. Polls rather than watches: the map arrives over virtiofs from the host, where inotify propagation is not something to depend on. An ino/size/mtime fingerprint keeps an untouched file from being re-parsed every TTL. Two safety rules, because a reload can now fail in production where startup could not: - A re-read that yields no people never disables an already-enabled map. `enabled === false` turns the operate gate off entirely, so a truncated or unparseable file would have failed open. The last good map keeps serving, marked unhealthy, and the next TTL retries. - requireOperateClaim no longer deletes the persisted claim of a person who is absent from the map. A half-written file can still parse as a valid map with a subset of people, and that delete is not reversible. Refusing operate is the gate; membership is re-checked on every operate, so a stale row grants nothing. Startup behaviour is unchanged: a missing or empty map still means the feature is off, and removing T3_IDENTITY_MAP_PATH remains the way to disable the gate. Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Author
|
Superseded by rebased tip + auto-resolve in #286; force-update of fork/identity must go through compose with deploy key. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Compose integration auto-rebase of
fork/identityonto currentfork/changesconflicts inapps/mobile/src/features/threads/thread-list-items.tsx(settled-row helpers from changes vs identity participation UI).Fix
Rebased the identity overlay commits onto current
fork/changesand resolved the import conflict by keeping both:ThreadIdentityLeading(identity overlay)resolveSettledRowTimestamp+resolveThreadStatus(changes settled rows)This PR replaces the stale overlay tip so compose can proceed. Prefer rebase merge / force-update of
fork/identityif branch rules allow; otherwise merge and re-run compose.