feat(server): isolate provider commands by thread - #289
Merged
Conversation
patroza
marked this pull request as ready for review
August 2, 2026 09:20
patroza
enabled auto-merge (squash)
August 2, 2026 09:20
patroza
force-pushed
the
feat/provider-command-thread-lanes
branch
from
August 2, 2026 09:21
96e4835 to
f8ff1db
Compare
patroza
added a commit
that referenced
this pull request
Aug 4, 2026
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
patroza
added a commit
that referenced
this pull request
Aug 4, 2026
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
patroza
added a commit
that referenced
this pull request
Aug 4, 2026
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
patroza
added a commit
that referenced
this pull request
Aug 5, 2026
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Orchestrator v2 alignment
This matches v2's
KeyedSerialExecutor<ThreadId>architecture: serialize within a thread, run unrelated threads concurrently, and remove keyed state after the last user. The v1 worker remains a queue-oriented wrapper because it additionally needs deterministicdrain()and explicit cancellation/drop of queued commands on thread deletion.Tests
vp checkELECTRON_SKIP_BINARY_DOWNLOAD=1 vp run -r --cache --log labeled typecheckvp test run packages/shared/src/DrainableWorker.test.ts packages/shared/src/KeyedDrainableWorker.test.ts apps/server/src/orchestration/Layers/ProviderCommandReactor.test.ts apps/server/integration/orchestrationEngine.integration.test.ts