feat(server): hot-swap-safe web serving + web-only deploy classification - #293
Merged
Conversation
…y deploys Groundwork for redeploying the web bundle without restarting the server. The server already serves dist/client live from disk per request, so replacing the bundle in place is picked up immediately -- but two gaps blocked a safe hot swap: 1. Compression cache could serve stale bytes. Stable-name files (favicon, manifest, ...) were keyed by path+mtime+size, so an atomic asset swap that preserved metadata could return old compressed bytes under new headers. Add isContentHashedAsset(): hashed assets (name encodes content) stay cheaply keyed by metadata; every stable-name file is now keyed by content, as index.html already was. 2. The deploy classifier lumped apps/web into a full server restart. Add a server_code flag and emit web_hot_swap=true when the server target is affected purely through its served bundle (no server process code changed), so ops can swap dist/client on the running server instead of restarting it. Desktop bundles its own copy and still rebuilds. Tests: isContentHashedAsset unit cases; classifier web_hot_swap cases for web-only, server-code, cross-boundary, and non-runtime diffs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
patroza
enabled auto-merge (squash)
August 2, 2026 15:56
patroza
disabled auto-merge
August 3, 2026 07:57
patroza
added a commit
that referenced
this pull request
Aug 4, 2026
…y deploys (#293) Groundwork for redeploying the web bundle without restarting the server. The server already serves dist/client live from disk per request, so replacing the bundle in place is picked up immediately -- but two gaps blocked a safe hot swap: 1. Compression cache could serve stale bytes. Stable-name files (favicon, manifest, ...) were keyed by path+mtime+size, so an atomic asset swap that preserved metadata could return old compressed bytes under new headers. Add isContentHashedAsset(): hashed assets (name encodes content) stay cheaply keyed by metadata; every stable-name file is now keyed by content, as index.html already was. 2. The deploy classifier lumped apps/web into a full server restart. Add a server_code flag and emit web_hot_swap=true when the server target is affected purely through its served bundle (no server process code changed), so ops can swap dist/client on the running server instead of restarting it. Desktop bundles its own copy and still rebuilds. Tests: isContentHashedAsset unit cases; classifier web_hot_swap cases for web-only, server-code, cross-boundary, and non-runtime diffs. Co-authored-by: Stack Test <stack-test@example.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
patroza
added a commit
that referenced
this pull request
Aug 4, 2026
…y deploys (#293) Groundwork for redeploying the web bundle without restarting the server. The server already serves dist/client live from disk per request, so replacing the bundle in place is picked up immediately -- but two gaps blocked a safe hot swap: 1. Compression cache could serve stale bytes. Stable-name files (favicon, manifest, ...) were keyed by path+mtime+size, so an atomic asset swap that preserved metadata could return old compressed bytes under new headers. Add isContentHashedAsset(): hashed assets (name encodes content) stay cheaply keyed by metadata; every stable-name file is now keyed by content, as index.html already was. 2. The deploy classifier lumped apps/web into a full server restart. Add a server_code flag and emit web_hot_swap=true when the server target is affected purely through its served bundle (no server process code changed), so ops can swap dist/client on the running server instead of restarting it. Desktop bundles its own copy and still rebuilds. Tests: isContentHashedAsset unit cases; classifier web_hot_swap cases for web-only, server-code, cross-boundary, and non-runtime diffs. Co-authored-by: Stack Test <stack-test@example.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
patroza
added a commit
that referenced
this pull request
Aug 4, 2026
…y deploys (#293) Groundwork for redeploying the web bundle without restarting the server. The server already serves dist/client live from disk per request, so replacing the bundle in place is picked up immediately -- but two gaps blocked a safe hot swap: 1. Compression cache could serve stale bytes. Stable-name files (favicon, manifest, ...) were keyed by path+mtime+size, so an atomic asset swap that preserved metadata could return old compressed bytes under new headers. Add isContentHashedAsset(): hashed assets (name encodes content) stay cheaply keyed by metadata; every stable-name file is now keyed by content, as index.html already was. 2. The deploy classifier lumped apps/web into a full server restart. Add a server_code flag and emit web_hot_swap=true when the server target is affected purely through its served bundle (no server process code changed), so ops can swap dist/client on the running server instead of restarting it. Desktop bundles its own copy and still rebuilds. Tests: isContentHashedAsset unit cases; classifier web_hot_swap cases for web-only, server-code, cross-boundary, and non-runtime diffs. Co-authored-by: Stack Test <stack-test@example.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
patroza
added a commit
that referenced
this pull request
Aug 5, 2026
…y deploys (#293) Groundwork for redeploying the web bundle without restarting the server. The server already serves dist/client live from disk per request, so replacing the bundle in place is picked up immediately -- but two gaps blocked a safe hot swap: 1. Compression cache could serve stale bytes. Stable-name files (favicon, manifest, ...) were keyed by path+mtime+size, so an atomic asset swap that preserved metadata could return old compressed bytes under new headers. Add isContentHashedAsset(): hashed assets (name encodes content) stay cheaply keyed by metadata; every stable-name file is now keyed by content, as index.html already was. 2. The deploy classifier lumped apps/web into a full server restart. Add a server_code flag and emit web_hot_swap=true when the server target is affected purely through its served bundle (no server process code changed), so ops can swap dist/client on the running server instead of restarting it. Desktop bundles its own copy and still rebuilds. Tests: isContentHashedAsset unit cases; classifier web_hot_swap cases for web-only, server-code, cross-boundary, and non-runtime diffs. Co-authored-by: Stack Test <stack-test@example.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groundwork for redeploying the web bundle without restarting the server (independent web deploys).
What
dist/clientlive from disk per request, so replacing the bundle in place is picked up immediately. Closed the one correctness gap: the in-memory compression cache keyed stable-name files (favicon,manifest, …) bypath+mtime+size, so an atomic asset swap that preserved metadata could serve stale compressed bytes. NewisContentHashedAsset()keeps content-hashed assets cheaply metadata-keyed (name encodes content) and keys every stable-name file by content, likeindex.htmlalready was.classify-deployment-diff.shlumpedapps/webinto a full server restart. Added aserver_codeflag and a newweb_hot_swap=trueoutput for when the server target is affected purely through its served bundle (no server process code changed) — so ops can hot-swapdist/clienton the running server instead of restarting it. Desktop bundles its own copy and still rebuilds.Why
Enables an additive-union hot swap (copy new hashed assets, atomically swap
index.html, GC old) with not3code-serverrestart. Clients already pick up new bundles via theno-cacheindex.html+vitePreloadRecoveryreload path.Tests
isContentHashedAssetunit cases (hashed vs stable-name).web_hot_swapcases: web-only, server-code, cross-boundary packages, discord-only, non-runtime.vp check0 errors; full recursive typecheck clean.Follow-ups (separate)
web_hot_swap.webVersionChangedWS signal so open/idle clients reload proactively (needs client verification).🤖 Generated with Claude Code