fix(mobile): declare the release_branch input on EAS development - #346
Merged
Conversation
The first fork/dev sync merge passed every required check and still ended as a failed run: Dispatch Mobile Releases got HTTP 422 "Unexpected inputs provided: [release_branch]" from mobile-eas-development.yml. Because the deploy poller only promotes a SHA whose fork-ci run concluded success, that failure blocked server, Discord, desktop and VS Code deployment of ae4719b entirely. #344 added the release_branch input declaration to mobile-eas-production.yml but only rewrote the usages in mobile-eas-development.yml, leaving it referencing inputs.release_branch without declaring it. The YAML validation in that PR printed the default for production and nothing for development, which was the evidence and was read past. Declare the input with the same fork/integration default so a manual dispatch that omits it is unchanged. Checked all three workflows for inputs.* references with no matching declaration; none remain. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
patroza
enabled auto-merge (squash)
August 6, 2026 06:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first
fork/devsync merge (ae4719b1c, #345) passed every required check and still endedas a failed run:
Because the deploy poller only promotes a SHA whose
fork-cirun concluded success, that onefailure blocked server, Discord, desktop and VS Code deployment of
ae4719b1centirely. The guest isstill sitting on
21badd04e.Cause
#344 added the
release_branchinput declarationto
mobile-eas-production.yml, but formobile-eas-development.ymlit only rewrote the usages —leaving the file referencing
inputs.release_branchwithout declaring it. Production dispatchsucceeded; development was rejected.
The validation in that PR printed the default for production and nothing for development. That was
the evidence, and it was read past.
Change
Declare the input with the same
fork/integrationdefault, so a manual dispatch that omits itbehaves exactly as before.
Validation
Rather than eyeball it again, all three workflows are now checked for
inputs.*references with nomatching declaration:
Separate design question, not fixed here
Should a release-dispatch failure invalidate a validation verdict?
Dispatch Mobile Releasesperforms a release action; the other five jobs validate the SHA. Mixing them in one run means any
dispatch hiccup — a 422, a transient API error — marks the SHA unapprovable and stalls the whole
fleet, which contradicts the handover doc's own rule that per-target release status is recorded
independently and that one target's failure must not hold back the others.
Two options, both one-liners:
continue-on-error: trueondispatch_mobile_releases— run concludes success, the failed jobstays visible, mobile status is tracked by the EAS workflows anyway.
push-triggered workflow sofork-ci's conclusion means "this SHAis valid" and nothing else.
I did not apply either, because weakening the deploy-approval signal is a policy call. Say which you
want and I'll do it.
Co-authored by @patroza
opened by Patrick Roza in chat thread Discord · Discord · T3