fix(web): show Monitoring on board cards instead of Working - #356
Merged
Conversation
The upstream import wired backgroundLiveness through the v1 pill and the v2 sidebar row, both of which render Monitoring as a distinct, deliberately calm state: the v1 pill sets pulse: false, and the v2 row uses a steady label with no duty-cycled shimmer per monitoring-pill D6. resolveSidebarV2TopStatus, which board cards read, was left folding monitoring into Working during that import because its label union had no Monitoring member. A watch loop therefore rendered on a board card with the active-progress shimmer -- precisely the treatment the other two surfaces avoid on purpose. Widen the union and give monitoring the same calm styling the v2 row uses. Board column bucketing is unchanged: Monitoring stays in the working bucket, since a monitoring thread is live rather than awaiting review. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Answering "is Monitoring properly adopted" — almost. Three of four surfaces were fine; board
cards were not, and that was my sync resolution.
Audit
resolveThreadStatusPill)label: "Monitoring",pulse: falseSidebarV2.tsx)label: "Monitoring", no icon, no shimmerBoard.logic.ts)Monitoring→ working bucketresolveSidebarV2TopStatus)resolveSidebarV2Statuscorrectly returns"monitoring", andSidebarV2Statuscarries it — butresolveSidebarV2TopStatus, whichBoardCardreads, folded it intoWorking.Why that was wrong
Not merely a cosmetic mismatch. Both other surfaces suppress motion for monitoring on purpose:
pulse: falsefor monitoring vspulse: truefor working.progress (monitoring-pill D6)."
A board card gave a watch loop
animate-sidebar-working-text— the active-progress shimmer — whichis exactly the treatment that design note exists to prevent.
Cause
Mine, from the #345 import. The union was
"Working" | "Approval" | "Input" | "Failed" | "Done"withno Monitoring member, and I folded the case in rather than widening it, with the comment "reads as
Working rather than inventing one". Widening was the right call — the label already existed in two
other surfaces, so it was not an invention.
Change
Widen the union and give monitoring the v2 row's calm styling. Board bucketing is untouched:
Monitoring stays in the working bucket, since a monitoring thread is live rather than awaiting
review.
Validation
Sidebar.logic.test.ts: 121 tests pass, including two new ones asserting monitoring is calmand working still animates, so the two cannot silently collapse again.
Co-authored by @patroza
opened by Patrick Roza in chat thread Discord · Discord · T3