ci(mobile): build labelled PR previews with the release profile#43
Merged
Conversation
The preview workflow built `preview:dev`, a development-client profile, so labelled PR builds ran unminified JavaScript with dev-only assertions. Those builds cannot show how a change behaves for performance or memory. Point the workflow at the plain `preview` profile and give it the two settings it was missing for that role: the fingerprint version policy, so the continuous-deploy-fingerprint action can still reuse compatible builds and publish OTA updates, and an APK Android build type, so the artifact linked from the PR installs directly. `preview:dev` stays for local Metro attachment. Also seed the preview EAS environment with the T3CODE_MOBILE_* variables that only the development environment carried, so remote builds resolve this fork's project instead of the upstream fallback. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Android has no signing keystore on the Expo project, so a `platform: all` preview build fails on credentials before the iOS artifact is published. Restore Android here once a keystore exists. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The preview workflow built the
preview:devprofile, which setsdevelopmentClient: true. Labelled PR builds therefore ran an unminified bundle with__DEV__assertions and React's development build — useful for attaching Metro, useless for judging how a change actually performs on device. A PR build should behave like the shipped app.What changed
.github/workflows/mobile-eas-preview.yml— the fingerprint deploy step now usesprofile: preview(release configuration).apps/mobile/eas.json— thepreviewprofile gains the two settings it needed to take over that role:MOBILE_VERSION_POLICY: fingerprint, socontinuous-deploy-fingerprintkeeps reusing compatible builds and publishing OTA updates to thepreviewchannel instead of forcing a native build per PR. The job-level env var never reached the EAS build servers.android.buildType: apk, so the Android artifact linked from the PR comment installs directly rather than being an unusable AAB.apps/mobile/README.md— documents that CI fingerprints the releasepreviewprofile and thatpreview:devremains for local Metro attachment.preview:devis unchanged and still reachable throughvp run eas:ios:preview:dev/eas:android:preview:dev.Out-of-band change
The
previewEAS environment had none of theT3CODE_MOBILE_*variables, so a remote preview build resolved the upstreampingdotggfallback and failed with theextra.eas.projectIdmismatch that broke the production builds earlier today. Seeded them on the Expo project (plaintext, project scope) to match thedevelopmentenvironment:T3CODE_MOBILE_EAS_PROJECT_ID,T3CODE_MOBILE_EXPO_OWNER,T3CODE_MOBILE_IOS_BUNDLE_IDENTIFIER,T3CODE_MOBILE_IOS_TEAM_ID.Verification
APP_VARIANT=preview eas config --platform ios --profile previewresolvesprojectId 731ac55d-…,owner patroza,dev.patroza.t3code.preview,runtimeVersion.policy fingerprint,distribution internal.Not yet exercised end to end: the
.preview,.preview.sharing, and.preview.widgetstargets still need ad-hoc provisioning profiles (eas credentials -p ios), and Android needs a keystore. Until then a labelled PR build will fail on credentials, exactly as the development workflow does today.🤖 Generated with Claude Code