Skip to content

test(server): stop flaky CI failures from wedging runs#60

Merged
patroza merged 1 commit into
fork/changesfrom
fix/ci-flaky-tests
Jul 25, 2026
Merged

test(server): stop flaky CI failures from wedging runs#60
patroza merged 1 commit into
fork/changesfrom
fix/ci-flaky-tests

Conversation

@patroza

@patroza patroza commented Jul 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • conservatively leave Git hook output unattributed because Trace2 lifecycle events and process output arrive on independently ordered streams
  • run both known flaky Grok interruption/cancellation assertions in detached fibers so their five-second timeout cannot wait indefinitely for cooperative shutdown
  • retain one retry and downgrade an unresolved Grok race to a warning, as intended

Why

Recent unrelated PRs repeatedly failed from nondeterministic server tests. Git hook output could be assigned to the wrong hook. Separately, two Grok cancellation tests could turn their local Effect timeouts into the suite-wide 120-second timeout by waiting on the wedged fiber they were interrupting.

Verification

  • pnpm exec vp test run src/git/GitManager.test.ts src/provider/Layers/GrokAdapter.test.ts (102 passed)
  • each affected Grok cancellation test passed in five repeated focused runs (1–2 seconds each)
  • server package typecheck passed; only pre-existing Effect suggestions in orchestration/decider.ts remain

@patroza
patroza force-pushed the fix/ci-flaky-tests branch from 7fdd30e to d906274 Compare July 25, 2026 16:02
@patroza
patroza merged commit 4581f54 into fork/changes Jul 25, 2026
10 checks passed
@patroza
patroza deleted the fix/ci-flaky-tests branch July 25, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant