test(server): make Grok flaky-test timeout a hard boundary#62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fiber.awaitinstead of joining themWhy
The prior mitigation still used
Fiber.join. Timing out that join propagated interruption into the provider test fiber and waited for its stuck finalizers, so integration CI could still hit Vitest’s global 120-second timeout. Awaiting the detached fiber’sExitkeeps observation independent from cancellation.Verification
Effect.nevercrosses the same await/timeout/cleanup boundary in 51 ms with a 50 ms timeout