Fix mobile-web image attachment submits#8
Merged
Conversation
patroza
added a commit
that referenced
this pull request
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
On iPhone, the native image picker updates our persisted composer draft synchronously. The submit handle previously read a ref updated later by a React effect, creating a race where the selected image appeared in state but the immediate send used an empty attachment list.
The integration CI failure was unrelated to Expo: the macOS job globally skips Electron downloads and then imported Electron in the focused test without running the repository repair/install step.
Verification
pnpm exec vp check apps/web/src/components/chat/ChatComposer.tsxpnpm exec vp test run apps/web/src/composerDraftStore.test.ts(74 passed)pnpm exec vp run --filter @t3tools/web typecheck