Skip to content

Fix mobile-web image attachment submits#8

Merged
patroza merged 1 commit into
fork/changesfrom
fix/mobile-web-attachments-ci
Jul 24, 2026
Merged

Fix mobile-web image attachment submits#8
patroza merged 1 commit into
fork/changesfrom
fix/mobile-web-attachments-ci

Conversation

@patroza

@patroza patroza commented Jul 24, 2026

Copy link
Copy Markdown
Owner

What changed

  • read the latest composer draft directly from the store when submitting, so an image selected through Tim Smart’s compact mobile upload button cannot be omitted before React synchronizes its mirror refs
  • use the same latest-draft snapshot for terminal and element context
  • install the Electron runtime in the macOS static-analysis job before running the focused Open With test

Why

On iPhone, the native image picker updates our persisted composer draft synchronously. The submit handle previously read a ref updated later by a React effect, creating a race where the selected image appeared in state but the immediate send used an empty attachment list.

The integration CI failure was unrelated to Expo: the macOS job globally skips Electron downloads and then imported Electron in the focused test without running the repository repair/install step.

Verification

  • pnpm exec vp check apps/web/src/components/chat/ChatComposer.tsx
  • pnpm exec vp test run apps/web/src/composerDraftStore.test.ts (74 passed)
  • pnpm exec vp run --filter @t3tools/web typecheck
  • isolated app server launched; collaborative browser verification was blocked by the preview tab retaining an invalid prior session credential

@patroza
patroza merged commit a872da5 into fork/changes Jul 24, 2026
6 checks passed
patroza added a commit that referenced this pull request Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant