feat: breaking change skill - #116
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughA new Changespf-react-breaking-changes skill addition
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsLinked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/migration/skills/pf-react-breaking-changes/SKILL.md`:
- Around line 1-7: The SKILL.md file frontmatter is missing the required
`disable-model-invocation: true` field. Since this skill writes a markdown
report file to the project root (pf-react-breaking-changes-report.md), it has
filesystem side effects and must declare this flag to prevent AI models from
invoking it programmatically. Add the `disable-model-invocation: true` field to
the YAML frontmatter in the skill definition.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 1d3a40c1-169c-4b76-b68d-25f5323b3a0a
📒 Files selected for processing (4)
PLUGINS.mdplugins/migration/README.mdplugins/migration/skills/pf-react-breaking-changes/SKILL.mdplugins/migration/skills/pf-react-breaking-changes/references/report-template.md
|
|
||
| ### 3. Load authoritative breaking changes | ||
|
|
||
| Use the **PatternFly MCP server** before guessing: |
There was a problem hiding this comment.
What happens if the user doesn't have the PatternFly MCP installed? Would a brief fallback sentence here (e.g., "If MCP is unavailable, reference the pf-codemods README and upgrade guide directly") prevent the AI from stalling when it can't find searchPatternFlyDocs?
|
|
||
| When MCP/docs identify a breaking change, search the codebase with targeted patterns: | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
Nit: these rg examples use PF5→PF6 component names (Chip, KebabToggle, Tile). Since the skill also targets minor/patch upgrades (line 87), would a brief note above clarifying these are PF5→PF6 illustrations help prevent the AI from searching for Chip during a 6.2→6.3 upgrade?
There was a problem hiding this comment.
🧹 Nitpick comments (1)
plugins/migration/skills/pf-react-breaking-changes/SKILL.md (1)
94-99: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winPin the codemods example.
@latestmakes this dry-run pull a moving npm target each time, so the skill can drift as upstream releases change. Please verify whether that is intentional; otherwise pin a released@patternfly/pf-codemodsversion here. Based on the static-analysis hint about unpinnednpxinvocations.Fix
- npx `@patternfly/pf-codemods`@latest --v6 <scan-path> + npx `@patternfly/pf-codemods`@<pinned-version> --v6 <scan-path>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@plugins/migration/skills/pf-react-breaking-changes/SKILL.md` around lines 94 - 99, The dry-run codemods example in SKILL.md is using a moving npm target via the PF codemods command, which should be pinned if that drift is not intentional. Update the example under the PF6 upgrade guidance to reference a specific released `@patternfly/pf-codemods` version instead of the current floating target, keeping the rest of the command structure unchanged. Please verify the example remains accurate for the documented machine-verification flow.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@plugins/migration/skills/pf-react-breaking-changes/SKILL.md`:
- Around line 94-99: The dry-run codemods example in SKILL.md is using a moving
npm target via the PF codemods command, which should be pinned if that drift is
not intentional. Update the example under the PF6 upgrade guidance to reference
a specific released `@patternfly/pf-codemods` version instead of the current
floating target, keeping the rest of the command structure unchanged. Please
verify the example remains accurate for the documented machine-verification
flow.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: da9ce4ee-91ef-4fad-897b-ec8dfcca68ae
📒 Files selected for processing (1)
plugins/migration/skills/pf-react-breaking-changes/SKILL.md
jpuzz0
left a comment
jpuzz0
left a comment
There was a problem hiding this comment.
LGTM, but you need to resolve the merge conflict with main.
2 participants
Created skill that checks for breaking changes by react.
Summary by CodeRabbit
New Features
@patternfly/react-*for API-breaking changes and generates a markdown report.Documentation