Skip to content
This repository was archived by the owner on Aug 11, 2026. It is now read-only.

feat(PF-4288): add plugin-workflows for aap-sdlc-harness integration - #129

Closed
jpuzz0 wants to merge 2 commits into
patternfly:mainfrom
jpuzz0:plugin-workflows-atat
Closed

feat(PF-4288): add plugin-workflows for aap-sdlc-harness integration#129
jpuzz0 wants to merge 2 commits into
patternfly:mainfrom
jpuzz0:plugin-workflows-atat

Conversation

@jpuzz0

@jpuzz0 jpuzz0 commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add plugin-workflows/aap-sdlc-harness/patternfly.md — maps PF skills to ATAT harness workflows (/code-review, /story-implementation-workflow)

Context

Part of AAP-78273 / PF-4288. The harness team requested that PF-specific workflow integration content be maintained by the PF team in this repo, rather than living in the harness repo where changes would require their review cycle.

The generic infrastructure (CLAUDE.md pointer, README, TEMPLATE) stays in the harness repo. The PF-specific content lives here, organized by consumer harness subdirectory so different products (ATAT, Firefly, etc.) can each have their own integration without conflicts.

Related MRs:

Closes: PF-4288

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds two markdown files: plugin-workflows/README.md documenting the plugin-workflows integration format (directory structure, setup copy mechanism, model consumption), and plugin-workflows/aap-sdlc-harness/patternfly.md specifying PatternFly-specific pre/post workflow steps triggered after /code-review and /story-implementation-workflow.

Changes

Plugin Workflow Integration Documentation

Layer / File(s) Summary
README and harness integration docs
plugin-workflows/README.md, plugin-workflows/aap-sdlc-harness/patternfly.md
README defines the directory layout, setup-time copy mechanism, and steps for adding new harness integrations. patternfly.md documents the conditions and concrete post-step invocations for /code-review (component structure validation, import checking, raw color scanning, token auditing) and /story-implementation-workflow (unit test generation, structure validation, import verification).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • patternfly/ai-helpers#29: Adds the pf-react:pf-library-test-writer skill referenced by patternfly.md's post-/story-implementation-workflow step for PatternFly-aware unit test generation.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the new plugin-workflows integration for the aap-sdlc-harness.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Your configuration references 1 linked repositories, but your current plan allows 0. Analyzed ``, skipped anthropics/claude-plugins-official.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
plugin-workflows/README.md (1)

8-12: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Add language specifier to fenced code block.

The directory tree block lacks a language tag, triggering markdownlint MD040. Add text or tree after the opening backticks.

+```text
plugin-workflows/
/
patternfly.md — PF skills mapped to that harness's workflows

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@plugin-workflows/README.md` around lines 8 - 12, The directory tree example
in the README is missing a fenced code block language tag, which triggers
markdownlint MD040. Update the fenced block in the plugin-workflows README to
include a language specifier such as text or tree on the opening backticks,
keeping the existing directory structure content intact.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@plugin-workflows/README.md`:
- Around line 8-12: The directory tree example in the README is missing a fenced
code block language tag, which triggers markdownlint MD040. Update the fenced
block in the plugin-workflows README to include a language specifier such as
text or tree on the opening backticks, keeping the existing directory structure
content intact.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a79a0f80-2994-4808-b636-6cdc1144ddeb

📥 Commits

Reviewing files that changed from the base of the PR and between 8e69cb5 and e593f7e.

📒 Files selected for processing (2)
  • plugin-workflows/README.md
  • plugin-workflows/aap-sdlc-harness/patternfly.md

@jpuzz0
jpuzz0 requested review from a team and dlabaj and removed request for a team June 29, 2026 17:47
The harness repo owns the pattern documentation. Plugin repos
just ship the workflow files.
@jpuzz0 jpuzz0 closed this Jun 29, 2026
@jpuzz0
jpuzz0 deleted the plugin-workflows-atat branch June 29, 2026 19:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant