This repository was archived by the owner on Aug 11, 2026. It is now read-only.
feat(ai-guidelines): skills framework - #62
Merged
jpuzz0 merged 20 commits intoMay 5, 2026
Conversation
Draft PR for a new Skill that checks for RH validates designers against established AI patterns
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughMoves AI experience pattern docs from ChangesDesign-Foundations: AI Experience Patterns (add) and React removals (delete)
Figma: pf-design-mode skill and approved sources
Governance, Security, Contribution rules
Automation / Workflows
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
moved into the design foundations folder
Added more reference materials and explicit rules to catch gradient usage.
andrew-ronaldson
marked this pull request as ready for review
April 29, 2026 15:35
Collaborator
|
@coderabbitai full review |
Contributor
✅ Actions performedFull review triggered. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugins/design-foundations/skills/ai-experience-patterns/SKILL.md`:
- Line 19: The skill text currently mentions the tool-specific phrase "Read
tool" (e.g., the sentence that begins "Show users the relevant reference images
from the `references/` folder using the Read tool" and the example outputs
referencing the "Read tool"); replace these mentions with a tool-agnostic
description of the desired outcome such as "retrieve and present the relevant
reference images from the `references/` folder" or "provide or embed the
reference images" so the guidance specifies what to do (display or provide links
to images from `references/`) without naming any specific tool or mechanism;
update all occurrences (including the example output blocks) to use this neutral
phrasing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 83961fe8-f3bb-4ffe-8dc0-00d40a1d6ade
⛔ Files ignored due to path filters (23)
plugins/design-foundations/skills/ai-experience-patterns/references/ai-generated-content-label.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/ai-icons-actions.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/ai-icons-in-use.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/ai-icons-information.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/ai-icons-overview.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/chat-message-dont-gradients.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/chat-messages-do-control-token.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/chatbot-avatar-donts.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/chatbot-avatar-in-use.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/chatbot-avatar-robot.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/chatbot-avatar-variations.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/chatbot-donts-gradients.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/chatbot-launch-button.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/chatbot-launch-examples.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/color-dos-donts.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/color-no-gradients.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/icons-do-this.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/icons-dont-create-new.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/icons-dont-use-without-disclosure.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/transparency-components.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/transparency-notices-chatbot.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/transparency-notices-features.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/transparency-requirement.pngis excluded by!**/*.png
📒 Files selected for processing (5)
plugins/design-foundations/skills/ai-experience-patterns/SKILL.mdplugins/design-foundations/skills/ai-experience-patterns/references/README.mdplugins/design-foundations/skills/ai-experience-patterns/references/REFERENCE-INDEX.mdplugins/react/skills/ai-experience-patterns/SKILL.mdplugins/react/skills/ai-experience-patterns/references/README.md
💤 Files with no reviewable changes (2)
- plugins/react/skills/ai-experience-patterns/references/README.md
- plugins/react/skills/ai-experience-patterns/SKILL.md
Remove references to Cursor Read tool.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugins/design-foundations/skills/ai-experience-patterns/SKILL.md`:
- Line 380: Replace the phrase "Always review AI-generated content prior to use"
with the shorter "Always review AI-generated content before use" in SKILL.md;
locate the exact string "Always review AI-generated content prior to use" and
make the substitution so the notice reads with the simplified wording.
- Line 5: Condense the long description value under the description key in
SKILL.md to under 250 characters while keeping the key trigger phrases
front‑loaded; update the description to a concise sentence that starts with "Use
when…" (or similar) and includes "AI experience", "AI powered", "chatbots",
"virtual assistants", "AI generation", and "product prototypes" so triggers
remain intact and the text stays <250 chars.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 22719da4-c110-4761-beca-7f59e7cc561b
📒 Files selected for processing (1)
plugins/design-foundations/skills/ai-experience-patterns/SKILL.md
…nduct (patternfly#61) ## Summary ### From AgentReady assessment (PF-3969) - Ran [AgentReady](https://github.com/ambient-code/agentready) baseline assessment. Score: 39.8/100 — most "failures" are categories that don't apply to a docs/plugin repo (lock files, src/tests layout, pre-commit hooks, etc.) - Added `SECURITY.md` — vulnerability reporting policy scoped to plugin/skill concerns - Added `CODE_OF_CONDUCT.md` — references Contributor Covenant v2.1 ### Independent of AgentReady - Added `GOVERNANCE.md` — three-layer review model documenting how contributions are validated: automated review (CodeRabbit), human review, and runtime permission boundaries - Added security-specific review instructions to `.coderabbit.yaml` for both SKILL.md files and bundled scripts - Added security rules section to `CONTRIBUTING-SKILLS.md` — what contributors must not do (hardcoded secrets, `curl | bash`, permission bypass, etc.) - Added optional evals guidance to `CONTRIBUTING-SKILLS.md` — points contributors to Anthropic's skill-creator eval framework for skills with structured output or external system interactions - Added Security & Governance section to `README.md` linking both docs ### What didn't we change? Most AgentReady categories are not applicable — this repo distributes Markdown plugins, not compiled code: - No lock files or package.json (no npm dependencies) - No src/tests directories (nothing to build or unit test) - No pre-commit hooks, commitlint, or linter configs (we follow conventional commits by convention) - No ADRs (decisions tracked in issues and commits) - No .editorconfig (contributors write markdown skill definitions — formatting is enforced by frontmatter structure and PR review, not editor config) Closes patternfly#54 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Added a Code of Conduct with private reporting instructions (public issues prohibited) * Added a Security policy for confidential vulnerability reporting, scope guidance for distributed AI plugins, and link to governance; only latest main branch supported * Added Governance guidance on contribution review and runtime safety guarantees * Updated contribution guidance with security rules and eval recommendations * Added Security & Governance references to the README * **Chores** * Enhanced automated review configuration with expanded security checks for plugins and scripts <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Collaborator
|
@coderabbitai full review |
Contributor
✅ Actions performedFull review triggered. |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
plugins/design-foundations/skills/ai-experience-patterns/SKILL.md (1)
43-56:⚠️ Potential issue | 🟡 Minor | 💤 Low valueNitpick: standardize the “prior to use” wording (use the shorter “before use”).
“Always review AI-generated content prior to use.” appears multiple times (e.g., in the transparency notices and the quick checklist). If the repo’s earlier guidance/lint prefers “before use” (shorter and more consistent), update all occurrences for consistency.
Also applies to: 375-381
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/design-foundations/skills/ai-experience-patterns/SKILL.md` around lines 43 - 56, Replace every occurrence of the sentence "Always review AI-generated content prior to use." with the shorter, standardized wording "Always review AI-generated content before use." Locate instances in the transparency notices (e.g., under the "For AI-assisted features" and "For virtual assistants/chatbots" sections), the quick checklist, and any other places where that exact sentence appears, and update them to match exactly; ensure spacing and punctuation remain consistent and run a repo-wide search to catch all matches.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@plugins/design-foundations/skills/ai-experience-patterns/references/README.md`:
- Around line 34-42: The README section "Using these references" hard-codes the
tool name "Claude" in the workflow; update the sentence "When building AI
experiences, Claude will:" to a tool-agnostic phrasing such as "When building AI
experiences, the assistant/skill will:" (or similar) throughout the paragraph so
it describes desired outcomes rather than a specific assistant; ensure
subsequent list items (Identify…, Reference…, Apply…, Document…) remain
unchanged except for any pronoun adjustments to match the new phrasing.
In `@plugins/design-foundations/skills/ai-experience-patterns/SKILL.md`:
- Around line 1-6: The frontmatter is malformed: replace the markdown headings
"## name: ai-experience-patterns" and "description: ..." with valid YAML keys
inside the initial frontmatter block and close it immediately; specifically,
change the start from "---" + "## name: ..." to a YAML block like "name:
ai-experience-patterns" and "description: Apply Red Hat's AI design language for
AI-powered demos and features. Use when user mentions AI experience, chatbots,
virtual assistants, AI generation, or product prototypes. Proactively applies
even without explicit request." followed by a closing "---" right after the
description, remove the stray closing "---" at the end of the file, and ensure
no other content remains inside the YAML block so the rest of the SKILL.md body
parses as markdown.
---
Duplicate comments:
In `@plugins/design-foundations/skills/ai-experience-patterns/SKILL.md`:
- Around line 43-56: Replace every occurrence of the sentence "Always review
AI-generated content prior to use." with the shorter, standardized wording
"Always review AI-generated content before use." Locate instances in the
transparency notices (e.g., under the "For AI-assisted features" and "For
virtual assistants/chatbots" sections), the quick checklist, and any other
places where that exact sentence appears, and update them to match exactly;
ensure spacing and punctuation remain consistent and run a repo-wide search to
catch all matches.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 02d043ee-a6a5-4953-8c4e-91f39549d0e2
⛔ Files ignored due to path filters (23)
plugins/design-foundations/skills/ai-experience-patterns/references/ai-generated-content-label.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/ai-icons-actions.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/ai-icons-in-use.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/ai-icons-information.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/ai-icons-overview.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/chat-message-dont-gradients.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/chat-messages-do-control-token.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/chatbot-avatar-donts.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/chatbot-avatar-in-use.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/chatbot-avatar-robot.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/chatbot-avatar-variations.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/chatbot-donts-gradients.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/chatbot-launch-button.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/chatbot-launch-examples.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/color-dos-donts.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/color-no-gradients.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/icons-do-this.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/icons-dont-create-new.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/icons-dont-use-without-disclosure.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/transparency-components.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/transparency-notices-chatbot.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/transparency-notices-features.pngis excluded by!**/*.pngplugins/design-foundations/skills/ai-experience-patterns/references/transparency-requirement.pngis excluded by!**/*.png
📒 Files selected for processing (5)
plugins/design-foundations/skills/ai-experience-patterns/SKILL.mdplugins/design-foundations/skills/ai-experience-patterns/references/README.mdplugins/design-foundations/skills/ai-experience-patterns/references/REFERENCE-INDEX.mdplugins/react/skills/ai-experience-patterns/SKILL.mdplugins/react/skills/ai-experience-patterns/references/README.md
💤 Files with no reviewable changes (2)
- plugins/react/skills/ai-experience-patterns/references/README.md
- plugins/react/skills/ai-experience-patterns/SKILL.md
jpuzz0
reviewed
Apr 30, 2026
| @@ -0,0 +1,424 @@ | |||
| --- | |||
|
|
|||
| ## name: ai-experience-patterns | |||
Collaborator
There was a problem hiding this comment.
The frontmatter is broken — in YAML, # is a comment character, so ## name: ai-experience-patterns is treated as a comment and name won't be set. There's also no closing --- delimiter. Should be name: ai-experience-patterns (no ##) with a closing --- after the description.
|
|
||
|
|
||
| | Failed Check | Show This Reference | | ||
| | ---------------------------------- | ------------------------------------------------------------------------- | |
Collaborator
There was a problem hiding this comment.
At 424 lines this is over the 200-line guideline. The reference-image mapping tables in Steps 3-4 here are a good candidate to extract into a file under references/ — that alone would cut ~100 lines.
|
|
||
| **Resources available:** | ||
|
|
||
| - `Design language_ AI-enabled features.pdf` - Full design guidelines (39 pages) |
Collaborator
There was a problem hiding this comment.
This references Design language_ AI-enabled features.pdf but the PDF isn't included in the PR. Either add it or remove the reference.
|
|
||
| ## Using these references | ||
|
|
||
| The skill automatically references the PDF guidelines. When building AI experiences, Claude will: |
Collaborator
There was a problem hiding this comment.
"Claude will:" is tool-specific — skills need to work in both Claude Code and Cursor. Use "the assistant will:" or similar.
Made-with: Cursor
Enables teams to design directly on the Figma canvas with patternfly guardrails in place <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Introduced a Figma design-mode skill with a write-focused, pattern-first workflow and guardrails for approved-asset use and safe edits. * **Documentation** * Updated installation and setup instructions for multiple agent platforms and clarified prerequisites requiring the official Figma plugin. * Added an approved design sources reference to ensure consistent, sanctioned assets. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Draft PR for a new Skill that checks for RH validates designers against established AI patterns
moved into the design foundations folder
Added more reference materials and explicit rules to catch gradient usage.
Remove references to Cursor Read tool.
…ronaldson/ai-helpers into ai-experience-guidelines
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/label-pf-team-issues.yml:
- Around line 13-14: Replace the mutable ref and broad secret inheritance to
eliminate supply-chain risk: change the reusable workflow reference in the uses
entry (currently
"patternfly/.github/.github/workflows/add-pf-team-label-workflow.yml@main") to a
pinned immutable commit SHA for that repo, and remove the "secrets: inherit"
line unless that specific secret inheritance is explicitly required by the
called workflow; if secrets are needed, pass only the minimal required secrets
by name instead of inheriting all.
In `@plugins/figma/README.md`:
- Around line 29-31: Update the fenced code block containing the plugin install
command "/add-plugin figma" to include the language identifier "bash" (i.e.,
replace the opening triple backticks with "```bash") so markdownlint MD040 is
satisfied and it matches other install commands in README.md; locate the block
that currently reads just "```" followed by "/add-plugin figma" and change the
opener to "```bash".
🪄 Autofix (Beta)
❌ Autofix failed (check again to retry)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 30ab167e-c402-4d9d-b23f-30bbf126c8cf
📒 Files selected for processing (11)
.coderabbit.yaml.github/workflows/label-pf-team-issues.ymlCODE_OF_CONDUCT.mdCONTRIBUTING-SKILLS.mdGOVERNANCE.mdPLUGINS.mdREADME.mdSECURITY.mdplugins/figma/README.mdplugins/figma/skills/pf-design-mode/SKILL.mdplugins/figma/skills/pf-design-mode/references/approved-sources.md
Comment on lines
+13
to
+14
| uses: patternfly/.github/.github/workflows/add-pf-team-label-workflow.yml@main | ||
| secrets: inherit |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# First, check if the file exists and read its full content
if [ -f ".github/workflows/label-pf-team-issues.yml" ]; then
cat -n ".github/workflows/label-pf-team-issues.yml"
else
echo "File not found"
find . -name "*label*" -type f | grep -E "\.yml|\.yaml"
fiRepository: patternfly/ai-helpers
Length of output: 397
🏁 Script executed:
#!/bin/bash
# Check if patternfly/.github is accessible or if we can find info about the reusable workflow
# Since we're in a different repo, let's look for any documentation or references
find . -name "*add-pf-team-label*" -o -name "*label-workflow*" 2>/dev/null | head -20Repository: anthropics/claude-plugins-official
Length of output: 60
🏁 Script executed:
#!/bin/bash
# Check git remote to understand the patternfly/.github relationship
git remote -v 2>/dev/null || echo "No git remotes"
# Look for any local references or documentation about the reusable workflow
grep -r "add-pf-team-label-workflow" . 2>/dev/nullRepository: patternfly/ai-helpers
Length of output: 324
Pin the reusable workflow to a commit SHA and remove broad secret inheritance
Line 13 uses a mutable ref (@main) while Line 14 inherits all secrets. Combined with the issues.opened trigger that allows any external user to run this workflow, this creates an avoidable supply-chain secret-exposure risk. If the upstream patternfly/.github repository is compromised, all secrets could be exfiltrated. Pin to an immutable commit SHA and remove secrets: inherit unless explicitly required by the reusable workflow.
Suggested fix
jobs:
label:
- uses: patternfly/.github/.github/workflows/add-pf-team-label-workflow.yml@main
- secrets: inherit
+ uses: patternfly/.github/.github/workflows/add-pf-team-label-workflow.yml@<commit-sha>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| uses: patternfly/.github/.github/workflows/add-pf-team-label-workflow.yml@main | |
| secrets: inherit | |
| jobs: | |
| label: | |
| uses: patternfly/.github/.github/workflows/add-pf-team-label-workflow.yml@<commit-sha> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/label-pf-team-issues.yml around lines 13 - 14, Replace the
mutable ref and broad secret inheritance to eliminate supply-chain risk: change
the reusable workflow reference in the uses entry (currently
"patternfly/.github/.github/workflows/add-pf-team-label-workflow.yml@main") to a
pinned immutable commit SHA for that repo, and remove the "secrets: inherit"
line unless that specific secret inheritance is explicitly required by the
called workflow; if secrets are needed, pass only the minimal required secrets
by name instead of inheriting all.
Created a new reference file to help shorten the skill and
Contributor
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. ⛔ CodeRabbit does not have permission to push changes to this repository. Please ensure CodeRabbit has Contents: Read and write permission. |
- Restore /plugin install figma@ai-helpers step accidentally removed from figma README - Fix broken code fence in design-foundations README (stray ```bash inside existing block) - Add bash language identifier to Cursor code block in figma README - Replace phantom PDF reference with pointer to REFERENCE-INDEX.md in ai-experience-patterns
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/design-foundations/skills/ai-experience-patterns/SKILL.md`:
- Line 2: Update the PatternFly-specific skill name to include the required pf-
prefix by changing the "name" value from "ai-experience-patterns" to
"pf-ai-experience-patterns" in the SKILL.md file and rename the containing
directory from "ai-experience-patterns" to "pf-ai-experience-patterns" so the
skill ID and directory match the PatternFly naming guideline; ensure any
internal references (imports or registry entries) that mention
ai-experience-patterns are updated to pf-ai-experience-patterns to avoid broken
references.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 76e940af-4c82-4d59-bc18-4d542b640438
📒 Files selected for processing (5)
plugins/design-foundations/skills/ai-experience-patterns/SKILL.mdplugins/design-foundations/skills/ai-experience-patterns/guidelines/design-rules.mdplugins/design-foundations/skills/ai-experience-patterns/guidelines/reference-mapping.mdplugins/design-foundations/skills/ai-experience-patterns/references/README.mdplugins/figma/README.md
| @@ -0,0 +1,146 @@ | |||
| --- | |||
| name: ai-experience-patterns | |||
Contributor
There was a problem hiding this comment.
Missing pf- prefix on PatternFly-specific skill name.
This skill is explicitly Red Hat/PatternFly-specific (references Red Hat design language, PatternFly components, rh-ui-icon-ai-* icons, Red Hat Brand Standards throughout), but the name lacks the required pf- prefix. As per coding guidelines, "Use the pf- prefix on skill and agent names that are PatternFly-specific."
The skill name should be pf-ai-experience-patterns, and the directory must be renamed to match: plugins/design-foundations/skills/pf-ai-experience-patterns/.
📝 Suggested fix
---
-name: ai-experience-patterns
+name: pf-ai-experience-patterns
description: Apply Red Hat's AI design language for AI-powered demos and features. Use when user mentions AI experience, chatbots, virtual assistants, AI generation, or product prototypes. Proactively applies even without explicit request.
---Then rename the directory from plugins/design-foundations/skills/ai-experience-patterns/ to plugins/design-foundations/skills/pf-ai-experience-patterns/.
As per coding guidelines: "Use the pf- prefix on skill and agent names that are PatternFly-specific. Do not prefix generic skills that could apply to any project."
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| name: ai-experience-patterns | |
| --- | |
| name: pf-ai-experience-patterns | |
| description: Apply Red Hat's AI design language for AI-powered demos and features. Use when user mentions AI experience, chatbots, virtual assistants, AI generation, or product prototypes. Proactively applies even without explicit request. | |
| --- |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@plugins/design-foundations/skills/ai-experience-patterns/SKILL.md` at line 2,
Update the PatternFly-specific skill name to include the required pf- prefix by
changing the "name" value from "ai-experience-patterns" to
"pf-ai-experience-patterns" in the SKILL.md file and rename the containing
directory from "ai-experience-patterns" to "pf-ai-experience-patterns" so the
skill ID and directory match the PatternFly naming guideline; ensure any
internal references (imports or registry entries) that mention
ai-experience-patterns are updated to pf-ai-experience-patterns to avoid broken
references.
Skill is PatternFly-specific (references Red Hat design language, PatternFly components, rh-ui-icon-ai-* icons) — requires pf- prefix per CONTRIBUTING-SKILLS.md.
jpuzz0
dismissed
coderabbitai[bot]’s stale review
May 5, 2026 23:54
comments addressed via claude code.
jpuzz0
approved these changes
May 5, 2026
This was referenced May 6, 2026
This was referenced Jun 5, 2026
This was referenced Jul 8, 2026
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR for a new Skill that validates designers against established RH AI components and patterns
Summary by CodeRabbit
Documentation
Refactor
New Features
Chores