feat(History): Add expandable sections - #879
Open
rebeccaalpert wants to merge 6 commits into
Open
Conversation
|
Preview: https://chatbot-pr-chatbot-879.surge.sh A11y report: https://chatbot-pr-chatbot-879-a11y.surge.sh |
rebeccaalpert
force-pushed
the
expandable-history
branch
2 times, most recently
from
July 22, 2026 13:59
0e4015b to
b4ceeb9
Compare
Assisted-by: Cursor
rebeccaalpert
force-pushed
the
expandable-history
branch
from
July 22, 2026 14:29
2b9337b to
ed64845
Compare
Assisted-by: Cursor
rebeccaalpert
force-pushed
the
expandable-history
branch
from
July 30, 2026 20:51
68c1f17 to
2b516cd
Compare
rebeccaalpert
marked this pull request as ready for review
July 30, 2026 20:58
thatblindgeye
left a comment
Collaborator
There was a problem hiding this comment.
In addition to the file comments below:
- This can be done in a separate PR since it's pre-existing, but each MenuGroup should be aria-labelledby referencing the visible text label of the group (
- For the show less/all button, that should probably follow the focus management in the "vieww more" Menu example where focus goes to the menuitem that replaced the "show all" button (in the new example in this PR, "Red Hat Certification"). When clicking the "Show less" button, focus should remain on the button as it updates to "Show all", though.
- It sorta feels a little odd that the "Saved prompts" toggle needs to be Tabbed to in order to expand it, but its contents become part of the general menu item navigation via up/down arrows keys. It almost feels like an entirely separate menu of things that should have its own menu navigation, but visually it looks like any other group of history items that can be navigated to via just up/down arrow keys. One thought was that the toggle should be a menuitem itself, but we don't typically do that for menu group titles.
rebeccaalpert
force-pushed
the
expandable-history
branch
from
August 3, 2026 19:18
881a7ae to
4d1ccc2
Compare
Member
Author
|
Addressed feedback! |
thatblindgeye
left a comment
Collaborator
There was a problem hiding this comment.
- Since we're adding some aria-labelledby logic already in this PR, let's also add the logic to label the actual Menu's by the MenuGroup text label as well. End result should be the
pf-v6-c-menuelement has aria-labelledby referencing the ID of thepf-v6-c-menu__group-titleelement. - Rather than an expandable group being part of the same Menu component as the other groups, wdyt about having them be their own unique Menus? So instead of
Menu > Pinned group, Chat group, Saved Prompts group, it'sMenu > Pinned group, Chat groupfollowed byMenu > Saved Prompts group? Then we don't necessarily need to autofocus the first item of the exapnded menu (Tabbing to the first item instead), and possibly it feels a little less odd that there's an expandable toggle in the middle of navigating between all the menuitems (since all the groups are part of the same Menu instance); instead you only are ablw to arrow through non-expandable menu items even when there's multiple groups, and you can only arrow through menuitems within that specific expandable menugroup
thatblindgeye
approved these changes
Aug 4, 2026
thatblindgeye
left a comment
Collaborator
There was a problem hiding this comment.
Just some lint issues needing fixing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API is somewhat tortured.
Fixes #864.