feat(ClipboardCopy): added truncation for inlinecompact variant #11610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatblindgeye
requested review from
a team,
christianvogt,
gitdallas,
mfrances17 and
tlabaj
and removed request for
a team
Collaborator
|
Preview: https://patternfly-react-pr-11610.surge.sh A11y report: https://patternfly-react-pr-11610-a11y.surge.sh |
gitdallas
approved these changes
Mar 6, 2025
Contributor
|
played around a little with the truncate props there |
gitdallas
suggested changes
Mar 6, 2025
Contributor
gitdallas
left a comment
gitdallas
left a comment
There was a problem hiding this comment.
actually, i wonder if we can make sure that the icon is inline with the text? seems like it is always going to the next level:
thatblindgeye
force-pushed
the
iss10890_clipboardTruncate
branch
from
7e8e6d3 to
db7d624
Compare
kmcfaul
approved these changes
Mar 11, 2025
wise-king-sullyman
approved these changes
Mar 11, 2025
mfrances17
approved these changes
Mar 12, 2025
gitdallas
approved these changes
Mar 12, 2025
thatblindgeye
force-pushed
the
iss10890_clipboardTruncate
branch
from
db7d624 to
96a3823
Compare
wise-king-sullyman
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #10890
Additional issues: