Skip to content

Update to PatternFly 6 #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fhlavac merged 23 commits into from
Jun 17, 2024
Merged

Update to PatternFly 6 #145

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
ad75ba2
feat(Status): Add Status component (#137)
fhlavac Jun 4, 2024
6c8e21c
RHCLOUD-30755 add ContentHeader component (#143)
aferd Jun 7, 2024
30647ca
Add BulkSelect component (#146)
fhlavac Jun 11, 2024
a87e04d
Bump PatternFly to v6
fhlavac Jun 14, 2024
6b1cd87
Migrate Ansible
fhlavac Jun 14, 2024
796fdf8
Migrate Battery
fhlavac Jun 14, 2024
46ed841
Migrate ContentHeader
fhlavac Jun 14, 2024
9c26300
Migrate ErrorState & ErrorBoundary
fhlavac Jun 14, 2024
cd5403e
Migrate InvalidObject
fhlavac Jun 14, 2024
d9afa9c
Migrate LogSnippet
fhlavac Jun 14, 2024
cfebb4e
Migrate MultiContentCard
fhlavac Jun 14, 2024
d3c3c7c
Migrate NotAuthorized
fhlavac Jun 14, 2024
415d080
Migrate Shortcut & ShortcutGrid
fhlavac Jun 14, 2024
25041e2
Migrate SkeletonTable
fhlavac Jun 14, 2024
8f1b699
Migrate Status & TagCount
fhlavac Jun 14, 2024
622517e
Migrate UnavailableContent
fhlavac Jun 14, 2024
becf098
Migrate WarningModal
fhlavac Jun 14, 2024
357b1db
Migrate DetailsPage
fhlavac Jun 14, 2024
8628c3a
Migrate BulkSelect
fhlavac Jun 14, 2024
7154eb6
Update @octokit/rest
fhlavac Jun 14, 2024
4855d1c
set up for alpha releasing
nicolethoen Jun 17, 2024
534d6be
fix most of the CI issues
nicolethoen Jun 17, 2024
7d09254
fix last test failure
nicolethoen Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Migrate WarningModal
  • Loading branch information
@fhlavac @nicolethoen
fhlavac authored and nicolethoen committed Jun 17, 2024
commit becf09886a1071b7ab1a018c98d6b6de87b8a8fe
5 changes: 3 additions & 2 deletions cypress/component/WarningModal.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ describe('WarningModal', () => {
it('renders WarningModal', () => {
cy.mount(<BasicModal />)
cy.get('button').click();
cy.get('[class="pf-v5-c-modal-box pf-m-warning pf-m-sm"').should('exist');
cy.get('div header h1 span').should('have.text', 'Warning alert:Unsaved changes');
cy.get('[data-ouia-component-id="WarningModal"]').should('exist');
cy.get('[data-ouia-component-id="WarningModal"]').contains('Unsaved changes');
cy.get('[data-ouia-component-id="WarningModal"]').contains('Your page contains unsaved changes. Do you want to leave?');
});
});
2 changes: 1 addition & 1 deletion packages/module/src/WarningModal/WarningModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ const WarningModal: React.FunctionComponent<WarningModalProps> = ({
onChange={(_event, value) => setChecked(value)}
label={checkboxLabel}
id="warning-modal-check"
className="pf-v5-u-mt-lg"
className="pf-v6-u-mt-lg"
ouiaId={`${ouiaId}-confirm-checkbox`}
/>
) : null}
Expand Down
42 changes: 21 additions & 21 deletions packages/module/src/WarningModal/__snapshots__/WarningModal.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,44 +4,44 @@ exports[`WarningModal component should render 1`] = `
{
"asFragment": [Function],
"baseElement": <body
class="pf-v5-c-backdrop__open"
class="pf-v6-c-backdrop__open"
>
<div
aria-hidden="true"
/>
<div>
<div
class="pf-v5-c-backdrop"
class="pf-v6-c-backdrop"
>
<div
class="pf-v5-l-bullseye"
class="pf-v6-l-bullseye"
>
<div
aria-describedby="pf-modal-part-2"
aria-labelledby="pf-modal-part-1"
aria-modal="true"
class="pf-v5-c-modal-box pf-m-warning pf-m-sm"
class="pf-v6-c-modal-box pf-m-warning pf-m-sm"
data-ouia-component-id="WarningModal"
data-ouia-component-type="PF5/ModalContent"
data-ouia-component-type="PF6/ModalContent"
data-ouia-safe="true"
id="pf-modal-part-0"
role="dialog"
>
<div
class="pf-v5-c-modal-box__close"
class="pf-v6-c-modal-box__close"
>
<button
aria-disabled="false"
aria-label="Close"
class="pf-v5-c-button pf-m-plain"
class="pf-v6-c-button pf-m-plain"
data-ouia-component-id="WarningModal-ModalBoxCloseButton"
data-ouia-component-type="PF5/Button"
data-ouia-component-type="PF6/Button"
data-ouia-safe="true"
type="button"
>
<svg
aria-hidden="true"
class="pf-v5-svg"
class="pf-v6-svg"
fill="currentColor"
height="1em"
role="img"
Expand All @@ -55,18 +55,18 @@ exports[`WarningModal component should render 1`] = `
</button>
</div>
<header
class="pf-v5-c-modal-box__header"
class="pf-v6-c-modal-box__header"
>
<h1
class="pf-v5-c-modal-box__title pf-m-icon"
class="pf-v6-c-modal-box__title pf-m-icon"
id="pf-modal-part-1"
>
<span
class="pf-v5-c-modal-box__title-icon"
class="pf-v6-c-modal-box__title-icon"
>
<svg
aria-hidden="true"
class="pf-v5-svg"
class="pf-v6-svg"
fill="currentColor"
height="1em"
role="img"
Expand All @@ -79,42 +79,42 @@ exports[`WarningModal component should render 1`] = `
</svg>
</span>
<span
class="pf-v5-screen-reader"
class="pf-v6-screen-reader"
>
Warning alert:
</span>
<span
class="pf-v5-c-modal-box__title-text"
class="pf-v6-c-modal-box__title-text"
>
Unsaved changes
</span>
</h1>
</header>
<div
class="pf-v5-c-modal-box__body"
class="pf-v6-c-modal-box__body"
confirmcheckmessage="hi there"
id="pf-modal-part-2"
>
Warning modal content
</div>
<footer
class="pf-v5-c-modal-box__footer"
class="pf-v6-c-modal-box__footer"
>
<button
aria-disabled="false"
class="pf-v5-c-button pf-m-primary"
class="pf-v6-c-button pf-m-primary"
data-ouia-component-id="WarningModal-confirm-button"
data-ouia-component-type="PF5/Button"
data-ouia-component-type="PF6/Button"
data-ouia-safe="true"
type="button"
>
Confirm
</button>
<button
aria-disabled="false"
class="pf-v5-c-button pf-m-link"
class="pf-v6-c-button pf-m-link"
data-ouia-component-id="WarningModal-cancel-button"
data-ouia-component-type="PF5/Button"
data-ouia-component-type="PF6/Button"
data-ouia-safe="true"
type="button"
>
Expand Down