Conversation
CHG: Updated project to 0.12
REM: spec-discovery dependency from bower.json
| "purescript-spec-discovery": "^2.0.0" | ||
| "purescript-psci-support": "^4.0.0", | ||
| "purescript-quickcheck": "^5.0.0", | ||
| "purescript-spec": "^3.0.0" |
There was a problem hiding this comment.
Why was purescript-spec-discovery removed? I'd like to keep using that.
There was a problem hiding this comment.
| "strings", | ||
| "tuples" | ||
| ] | ||
| } |
There was a problem hiding this comment.
Seems fine to me, but I think the proper way to answer that question is to run it on CI. It's easy for this sort of duplication to get out of sync if it's not checked all the time.
| import Data.String (Pattern(..)) | ||
| import Data.String as String | ||
| import Data.Tuple (Tuple(..)) | ||
| import Prelude |
There was a problem hiding this comment.
Could you move this back please?
| import Test.QuickCheck (class Arbitrary, arbitrary, (===), quickCheck) | ||
| import Test.QuickCheck.Gen (oneOf) | ||
| import Test.Spec (Spec, describe, it) | ||
| import Test.Spec.QuickCheck (QCRunnerEffects, quickCheck) |
There was a problem hiding this comment.
Is purescript-spec-quickcheck redundant in 0.12? cc @owickstrom
| describe "text" do | ||
| it "is a homomorphism from string concatenation to document concatenation" do | ||
| it "is a homomorphism from string concatenation to document concatenation" | ||
| $ liftEffect do |
There was a problem hiding this comment.
Could you put this onto the same line as it, like the rest?
|
We'd also need to use node 10 and |
|
Closing in favor of #13. Thanks anyway @eric-corumdigital! |
3 participants
No description provided.