Skip to content

Refactor Request to include named context field #80

Description

@DanGould

Request.uri and Request.body still need to be marshaled into an http library's client. In working through the issue with a dev, I think it would be more ergonomic to just return (uri: Uri, body: Vec<u8>)

After seeing the tuple solution in practice, I think it would make more sense to name context as a field in Request and have create_pj_request return Request instead of (Request, Context). tuples are not as intuitive since they lack the documentation in the form of a name or a docstring

Metadata

Metadata

Assignees

No one assigned

    Labels

    apigood first issueDoes NOT mean "an LLM can do this." Please discuss the constraints and intended approach.sendsending payjoin

    Type

    No type

    Projects

    Status
    Done

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions