Fetching ohttp-keys should time out quickly#1005
Merged
Merged
Conversation
This pr adds a timeout time of 10 seconds when trying to connect to a relay and for some reason it fails . addresses payjoin#968
Collaborator
Pull Request Test Coverage Report for Build 17278728526Details
💛 - Coveralls |
Member
|
This has me wondering also, since fetching can happen multiple times, if the client should later be cached or re-used so that it can get a performance edge or if that only makes sense for custom clients and not the one we ship with |
Collaborator
|
Tangential to this issue, I also wonder if implementers could parallelize requests to multiple ohttp relays instead of trying them sequentially, and process whatever response returns first. |
Member
|
It'd be nice to be able to test this experience, ESPECIALLY IN MOBILE! but I'll merge this for now. I'll open an "audit network disruption experience" issue. |
This was referenced Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds a timeout time of 10 seconds when trying to connect to a relay and the response time is longer than normal . addresses #968
Pull Request Checklist
Please confirm the following before requesting review: