Implement Serverless Payjoin BIP by DanGould · Pull Request #101 · payjoin/rust-payjoin

DanGould · 2023-08-19T21:06:44Z

Ongoing design discussion: https://delvingbitcoin.org/t/serverless-payjoin-protocol-design/96

Communicate payjoin asynchronously via HTTP Polling(single buffer)
Multiple Buffers, BIP21 identification & allocation
Base64Url (☐ or Blockchain Commons UR) encoding in BIP21
e2ee + authentication
Message Padding
OHTTP (☐ with 🆕 draft standard secp256k1 HPKE)

Refactors for better production quality

Prior Attempts:

Noise NNpsk0 cryptosystem: Serverless PayJoin PoC (HTTP Long Polling) #21
Backwards compatible demo: REElay 😡: BIP 78-compatible Gullible Payjoin PoC (WebSockets) #78
WebSockets w/ custom crypto ~Noise NN/HPKI: https://github.com/dangould/rust-payjoin/tree/serverless-payjoin-sockets
WebTransport w/ custom crypto ~Noise NN/HPKI: https://github.com/dangould/rust-payjoin/tree/serverless-payjoin-webtransport

jbesraa

So I just did a review to understand the implementation and link it the actual BIP. I went through the BIP again also while reviewing this so it is a great refreshment. the code is quite readable and its not too hard to link to the different parts of the BIP.
I added a few comments to make sure I get things correctly. Ill review this a couple of more times and might have a bit more code/design input then.

DanGould · 2023-12-06T02:00:16Z

+                } else if endpoint.scheme() == "http" {
+                    Ok(Payjoin::V2Only(PayjoinParams {
+                        _endpoint: endpoint,
+                        disable_output_substitution: pjos.unwrap_or(false),
+                    }))


Although v2 is secure with plain http because sender - receiver communications are e2ee using hpke, it adds complexity to the library and specifically THIS PR which is now only used in places which also support https

DanGould · 2023-12-06T02:03:43Z

 [features]
 send = []
 receive = ["rand"]
+relay = []


this is never used

DanGould · 2023-12-06T02:05:23Z

+            let http = reqwest::Client::builder()
+                .danger_accept_invalid_certs(true)
+                .build()
+                .expect("Failed to build reqwest http client");


Although reqwest is easier to use with tokio than ureq, it's a new dep and makes comparing this to the existing integration more burdenome

DanGould · 2023-12-06T02:05:49Z

-reqwest = { version = "0.11.4" }
+reqwest = { version = "0.11.4" }


DanGould · 2023-12-06T02:08:36Z

 }

+async fn post_enroll(body: Body) -> Result<Response<Body>, HandlerError> {
+    use payjoin::{base64, bitcoin};


these dependencies are independent reexports of payjoin. consider depending on them directly

DanGould · 2023-12-06T02:26:51Z

    MultipleParams(&'static str),
    MissingEndpoint,
    NotUtf8(core::str::Utf8Error),
+    NotBase64(bitcoin::base64::DecodeError),


cfg feature v2 only?

DanGould · 2023-12-06T02:27:14Z

 use std::{error, fmt};

 pub const MAX_BUFFER_SIZE: usize = 65536;
-pub const RECEIVE: &str = "receive";


this can actually be removed in the postgres / subdir introduction

DanGould · 2023-12-06T02:28:04Z

-    message_a: &mut [u8],
-    s: SecretKey,
-) -> Result<(Vec<u8>, PublicKey), Error> {
+pub fn decrypt_message_a(message_a: &[u8], s: SecretKey) -> Result<(Vec<u8>, PublicKey), Error> {


can this be immutable from the getgo?

DanGould · 2023-12-06T02:30:25Z

+    #[cfg(feature = "v2")]
+    async fn long_poll_post(&self, req_ctx: payjoin::send::RequestContext<'_>) -> Result<Psbt> {
+        loop {
+            let (req, ctx) = req_ctx.extract_v2(&self.config.ohttp_proxy)?;


I suppose the loops could be contained within one function that takes this line as a closure

DanGould · 2023-12-06T02:33:07Z

+use std::fmt;
+use std::str::FromStr;
+
+use serde::de::{self, Deserializer, MapAccess, SeqAccess, Visitor};


should be at file top

Use postgres and hyper to store and notify clients' updates.

DanGould · 2023-12-11T15:50:12Z

This functionality is complete and includes comprehensive testing

However it is rought around the edges and could be a bit more organized with module separation. I'm going to merge it to consider new organizations in independent pull requests

DanGould added enhancement New feature or request payjoin-cli receive receiving payjoin send sending payjoin payjoin-mailroom api labels Aug 19, 2023

DanGould force-pushed the serverless-payjoin branch 2 times, most recently from bb4c1f2 to 9230962 Compare August 23, 2023 16:48

DanGould force-pushed the serverless-payjoin branch 2 times, most recently from b47590c to bb2b531 Compare September 12, 2023 17:49

DanGould force-pushed the serverless-payjoin branch from bb2b531 to d742829 Compare September 24, 2023 16:24

This was referenced Sep 25, 2023

Replace Configuration with RequestBuilder to replace PjUri::create_pj_request #19

Closed

Replace Configuration with ergonomic RequestBuilder #106

Merged

DanGould force-pushed the serverless-payjoin branch 2 times, most recently from c999b55 to 5834266 Compare September 29, 2023 21:56

jbesraa reviewed Oct 2, 2023

View reviewed changes

Comment thread payjoin-cli/src/app.rs

Comment thread payjoin-relay/src/main.rs Outdated

Comment thread payjoin-relay/src/main.rs Outdated

DanGould force-pushed the serverless-payjoin branch from 5834266 to b46dac1 Compare October 2, 2023 15:28

DanGould force-pushed the serverless-payjoin branch from b46dac1 to 38f7dc1 Compare October 24, 2023 21:49

DanGould force-pushed the serverless-payjoin branch 3 times, most recently from 9eb5cfc to aca9982 Compare November 6, 2023 22:43

DanGould force-pushed the serverless-payjoin branch 3 times, most recently from b44a085 to c0ce861 Compare November 20, 2023 22:37

DanGould force-pushed the serverless-payjoin branch 2 times, most recently from 28cef51 to e66f80d Compare December 5, 2023 21:04

DanGould commented Dec 6, 2023

View reviewed changes

DanGould force-pushed the serverless-payjoin branch from e66f80d to ee76271 Compare December 11, 2023 02:21

DanGould marked this pull request as ready for review December 11, 2023 02:26

DanGould force-pushed the serverless-payjoin branch from ee76271 to 7d08034 Compare December 11, 2023 15:07

DanGould force-pushed the serverless-payjoin branch 4 times, most recently from 34d16e0 to e386f4f Compare December 11, 2023 15:14

DanGould added 5 commits December 11, 2023 10:21

Store and forward v2 messages with payjoin-relay

933fd5b

Use postgres and hyper to store and notify clients' updates.

De/Serialize v2 payload

a8c4d2b

Secure v2 payloads with authenticated encryption

a1d090c

Protect metadata with Oblivious HTTP

5935775

Send and receive v2 via cli

b065521

DanGould force-pushed the serverless-payjoin branch from e386f4f to 97c5adf Compare December 11, 2023 15:31

Impl traits for session persistence

f81f401

DanGould force-pushed the serverless-payjoin branch from 97c5adf to f81f401 Compare December 11, 2023 15:32

DanGould merged commit f87424e into payjoin:master Dec 11, 2023

This was referenced Dec 11, 2023

Improve v1 / v2 module separation #132

Closed

Run v1 v2 integration tests #133

Merged

		reqwest = { version = "0.11.4" } No newline at end of file
		reqwest = { version = "0.11.4" }

Uh oh!

Conversation

DanGould commented Aug 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Refactors for better production quality

Prior Attempts:

Uh oh!

jbesraa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DanGould commented Dec 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

DanGould commented Aug 19, 2023 •

edited

Loading