Document OHTTP relay random selection guidance#1380
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 22864083973Details
💛 - Coveralls |
bc1cindy
marked this pull request as ready for review
March 4, 2026 13:39
DanGould
requested changes
Mar 4, 2026
DanGould
left a comment
Member
There was a problem hiding this comment.
This is the right direction but raised some questions I don't have the answers for yet about whether the pattern this is documenting is actually a desirable one sufficient for reference.
This was referenced Mar 6, 2026
bc1cindy
force-pushed
the
docs/ohttp-relay
branch
from
March 9, 2026 16:40
d5580ab to
52c370e
Compare
Contributor
Author
|
I'm feeling this is blocked until we reach #1385 |
Member
|
I think we've got answers for #1385 @bc1cindy but I'm skeptical that this PR actually closes #1328 until it employs the consensus opinions of #1385 Because of that I edited your OP to say "Re: " instead of "Closes" so that the issue stays open. I welcome another PR to address the issue but want to merge this for the sake of triage and keeping it moving to close the thread. |
DanGould
approved these changes
Apr 29, 2026
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed relay order creates a fingerprintable pattern at the network layer, even though OHTTP protects the user's IP. Document that callers should select relays randomly and track failed ones for resilience, following the existing
RelayManagerimplementation inpayjoin-cli.Claude sonnet 4.6 helped me doing the research of the issue.
Re: #1328
Please confirm the following before requesting review:
AI
in the body of this PR.