Skip to content

Document OHTTP relay random selection guidance#1380

Merged
DanGould merged 1 commit into
payjoin:masterfrom
bc1cindy:docs/ohttp-relay
Apr 29, 2026
Merged

Document OHTTP relay random selection guidance#1380
DanGould merged 1 commit into
payjoin:masterfrom
bc1cindy:docs/ohttp-relay

Conversation

@bc1cindy

@bc1cindy bc1cindy commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Fixed relay order creates a fingerprintable pattern at the network layer, even though OHTTP protects the user's IP. Document that callers should select relays randomly and track failed ones for resilience, following the existing RelayManager implementation in payjoin-cli.

Claude sonnet 4.6 helped me doing the research of the issue.

Re: #1328

Please confirm the following before requesting review:

@coveralls

coveralls commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 22864083973

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.497%

Totals Coverage Status
Change from base Build 22741440695: 0.0%
Covered Lines: 10638
Relevant Lines: 12895

💛 - Coveralls

@bc1cindy
bc1cindy marked this pull request as ready for review March 4, 2026 13:39

@DanGould DanGould left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the right direction but raised some questions I don't have the answers for yet about whether the pattern this is documenting is actually a desirable one sufficient for reference.

Comment thread payjoin-cli/src/app/v2/ohttp.rs Outdated
Comment thread payjoin-cli/src/app/v2/ohttp.rs Outdated
Comment thread payjoin/src/core/io.rs Outdated
@bc1cindy

Copy link
Copy Markdown
Contributor Author

I'm feeling this is blocked until we reach #1385

@DanGould

DanGould commented Apr 29, 2026

Copy link
Copy Markdown
Member

I think we've got answers for #1385 @bc1cindy

but I'm skeptical that this PR actually closes #1328 until it employs the consensus opinions of #1385

Because of that I edited your OP to say "Re: " instead of "Closes" so that the issue stays open. I welcome another PR to address the issue but want to merge this for the sake of triage and keeping it moving to close the thread.

@DanGould
DanGould merged commit 9d72dfe into payjoin:master Apr 29, 2026
14 checks passed
@benalleng benalleng mentioned this pull request Jun 7, 2026
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants