Skip to content

Constrain bitcoind client API version#1636

Merged
chavic merged 1 commit into
payjoin:masterfrom
DanGould:constrain-bitcoindrpcclient-lt-1010
Jun 11, 2026
Merged

Constrain bitcoind client API version#1636
chavic merged 1 commit into
payjoin:masterfrom
DanGould:constrain-bitcoindrpcclient-lt-1010

Conversation

@DanGould

Copy link
Copy Markdown
Member

breaking change got released as a point release in bitcoind-async-client accidentally

This constraint fixes that. Discovered in #1610

Pull Request Checklist

Please confirm the following before requesting review:

@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 27341668566

Warning

No base build found for commit 2e39c7f on master.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 85.188%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 14718
Covered Lines: 12538
Line Coverage: 85.19%
Coverage Strength: 370.94 hits per line

💛 - Coveralls

@bc1cindy bc1cindy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@chavic

chavic commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

ACK, @DanGould will we need an issue for relaxing this once upstream acts? Say they yank and re-release the package version

@chavic
chavic merged commit 4c2b7c8 into payjoin:master Jun 11, 2026
14 checks passed
@DanGould

Copy link
Copy Markdown
Member Author

@chavic upstream suggested we update to 13.1 which doesn't have this breaking change, but I think we just want to get on 0.14 alpenlabs/bitcoind-async-client#124 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants