Assert bech32 encoding is uppercase#1666
Merged
Merged
Conversation
Collaborator
Coverage Report for CI Build 27916857142Coverage increased (+0.001%) to 85.214%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
chavic
marked this pull request as ready for review
June 21, 2026 21:04
chavic
requested review from
DanGould and
xstoicunicornx
and removed request for
DanGould
June 21, 2026 21:05
xstoicunicornx
approved these changes
Jun 22, 2026
xstoicunicornx
left a comment
xstoicunicornx
left a comment
Collaborator
There was a problem hiding this comment.
utACK 05c8d43
Seems good to take care of this todo that asserts that encoded value should be uppercase. Added assert looks good and tested this locally.
Merged
benalleng
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the placeholder TODO in the bech32 QR encoding test with an explicit uppercase assertion.
Disclosure: co-authored by Codex