Remove Completed at history column#1683
Merged
Merged
Conversation
benalleng
force-pushed
the
cli-expiry-history
branch
2 times, most recently
from
June 25, 2026 16:54
d5e0f58 to
48013e2
Compare
Collaborator
Coverage Report for CI Build 28456757529Coverage increased (+0.07%) to 85.748%Details
Uncovered Changes
Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
caarloshenriq
approved these changes
Jun 25, 2026
caarloshenriq
left a comment
caarloshenriq
left a comment
Contributor
There was a problem hiding this comment.
tACK 48013e2
Reviewed and tested the changes locally, works as expected.
spacebear21
reviewed
Jun 25, 2026
spacebear21
left a comment
spacebear21
left a comment
Collaborator
There was a problem hiding this comment.
cACK however there seems to be an unrelated behavior change to the resume command that snuck in here, I think because of the move the SessionStatus as a source of truth.
benalleng
force-pushed
the
cli-expiry-history
branch
2 times, most recently
from
June 27, 2026 13:44
9107045 to
416e949
Compare
Collaborator
Author
|
This PR is beginning to grow out of scope I am going to break out the cli UX seperately from the pure remove |
benalleng
force-pushed
the
cli-expiry-history
branch
from
June 27, 2026 13:47
416e949 to
6e55225
Compare
This removes the completed at column from the history command as this only showed the timestamp that the session reached a terminal state. This is really only useful for the DB internals and not really a UX benefit for a user.
benalleng
force-pushed
the
cli-expiry-history
branch
from
June 30, 2026 15:39
6e55225 to
5c673ff
Compare
Collaborator
Author
|
Dropped the DB removal following the discussion in #1651 this PR now only drops the History display column |
spacebear21
approved these changes
Jun 30, 2026
spacebear21
left a comment
spacebear21
left a comment
Collaborator
There was a problem hiding this comment.
ACK 5c673ff which is a display-only change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was originally removing both the Completed At History column and DB completed at but now only removes the UI element in the History command. I will still make a follow-up for some readability enhancements for fallback transaction availability and session Id identification.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.