Add Spec related consts for better readability in tests#1699
Merged
Conversation
This is a followup on payjoin#1622 to add consts for the MAX_ADDITIONAL_FEE_CONTRIBUTION and ADDITIONAL_FEE_OUTPUT_INDEX to better understand why these values are included in unit tests across the codebase.
DanGould
approved these changes
Jun 30, 2026
Collaborator
Coverage Report for CI Build 28456015348Coverage remained the same at 85.681%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup on #1622 to add consts for the
MAX_ADDITIONAL_FEE_CONTRIBUTION and ADDITIONAL_FEE_OUTPUT_INDEX to better understand why these values are included in unit tests across the codebase.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.