Pin bindings CI to the maintained lockfile#1748
Merged
Merged
Conversation
The bindings test scripts ran bare cargo with no lockfile, so every CI run resolved the whole dependency graph to the latest crates. tokio 1.53.0 made the cost concrete: it resolves as 1.85-compatible but uses Once::wait, stabilized in 1.86, in its Windows-only signal code, which broke the Windows csharp job on every pull request. Source contrib/lockfile.sh and build against Cargo-recent.lock in the four bindings test entry points, the same mechanism the Rust jobs use and the lock-maintenance workflow keeps updated. The Windows csharp entry point mirrors it in PowerShell since lockfile.sh is bash. lockfile.sh now records absolute paths: its EXIT trap restored the lockfile relative to the current directory, which silently no-ops for callers that change directory after use_lockfile, as these scripts do. The detached payjoin-ffi/dart/native wrapper workspace still resolves fresh and is left for a separate change.
2 tasks
Collaborator
Author
|
Note for sequencing: #1707 touches |
Collaborator
Coverage Report for CI Build 29582554365Coverage remained the same at 86.187%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bindings workflows (csharp, dart, python, javascript) never use the repository's lockfile mechanism, so every CI run resolves the full dependency graph fresh, and today that broke every PR's Windows csharp job: tokio 1.53.0 resolves as 1.85-compatible but uses
Once::wait(stabilized in 1.86) in its Windows-only signal code. This wires the samecontrib/lockfile.sh+Cargo-recent.lockmechanism the Rust jobs already use into the four bindings test entry points, with a PowerShell mirror for the Windows csharp entry, restoring the previous lockfile state on exit. The detachedpayjoin-ffi/dart/nativewrapper workspace still resolves fresh and is left for a separate change.Disclosure: co-authored by Claude Code.