Refactor payjoin-cli v1, v2 modules#198
Merged
Merged
Conversation
DanGould
force-pushed
the
hex-app
branch
4 times, most recently
from
February 19, 2024 15:12
efd8b9b to
9516d4d
Compare
DanGould
marked this pull request as ready for review
February 19, 2024 15:33
Member
Author
|
@jbesraa Separating |
3 tasks
jbesraa
approved these changes
Feb 20, 2024
jbesraa
left a comment
jbesraa
left a comment
Contributor
There was a problem hiding this comment.
Concept ACK.
Really like the new design with the trait and file separation! makes the code much more comprehensive and readable!
| #[cfg(feature = "v2")] | ||
| let is_retry = matches.get_one::<bool>("retry").context("Could not read --retry")?; | ||
| #[cfg(feature = "v2")] | ||
| let is_retry = matches.get_one::<bool>("retry").unwrap_or(&false); |
Contributor
There was a problem hiding this comment.
are you planning to take this out in a different PR?
Member
Author
There was a problem hiding this comment.
Yes, I'll follow up with it's removal. This was focused on the module separation only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that I used the async-trait crate because we target msrv 1.63.0
msrv 1.70 allows async traits out of the box, so when we target that we can remove the dependency