Clean up V2 errors - #223
Merged
Merged
Conversation
The internal/external pattern is for public types which may change.
DanGould
commented
Mar 25, 2024
| FeeRateBelowMinimum => write!(f, "the fee rate of proposed transaction is below minimum"), | ||
| #[cfg(feature = "v2")] | ||
| V2(e) => write!(f, "v2 error: {}", e), | ||
| HpkeError(e) => write!(f, "v2 error: {}", e), |
Member
Author
There was a problem hiding this comment.
I'm not the happiest with this error string, but we should be reconsidering the context we want to keep with send::Error anyhow in a later issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#220 uncovered an issue with the OhttpKeys::decode return error type returning an internal error. I think it still makes sense to return the internal
ohttp::Errorrather than wrapping it in another type that gives no additional context. That also led me to clean up the whole module's error handling.Fix #222
Fix #142