Bech32m encode HPKE PublicKey, OhttpKeys - #229
Closed
DanGould wants to merge 2 commits into
Closed
Conversation
Bech32m has a human-readable prefix, checksum, creates smaller QR codes, and is already available in rust-bitcoin. It's a much better encoding scheme than base64 for bip21 uri params.
DanGould
marked this pull request as draft
April 3, 2024 00:18
Member
Author
|
bip21 URIs are not alphanumeric mode encodable since they use '=' and '?' characters. Therefore, base64URI seems to be the appropriate encoding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bech32m has a human-readable prefix, checksum, creates smaller
QR codes, and is already available in rust-bitcoin.
It's a much better encoding scheme than base64 for bip21 uri params.
This supersedes #226.
Bech32m is a better encoding scheme than bytewords because it's both more dense than bytewords because its character set includes digits based on base32 encoding and it doesn't introduce a new dependency.
bech32is already part of rust-bitcoin.