Construct Uri from Enrolled method - #236
Closed
DanGould wants to merge 1 commit into
Closed
Conversation
DanGould
marked this pull request as draft
April 28, 2024 17:24
DanGould
commented
May 1, 2024
| } | ||
| } | ||
|
|
||
| pub fn pj_uri_builder(&self, address: Address) -> Result<PjUriBuilder, Error> { |
Member
Author
There was a problem hiding this comment.
does it make sense for this to be fallable if this state is already Enrolled, proving the pj_url correct? Shouldn't enrolling fail if no pj_url is available?
Member
Author
|
Closed by #283 with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #205
I chose to actually return a
PjUriBuildersince it lets the downstream implementor construct the rest of the Uri.Question: Are any downstream implementations constructing their own URIs which would have a problem with this return type? or can they extract the necessary Uri parameters from the builder?