Improve payjoin-cli ergonomics - #275
Merged
Merged
Conversation
| .await | ||
| .map_err(map_reqwest_err)?; | ||
| let res = payjoin_proposal | ||
| let _res = payjoin_proposal |
Collaborator
There was a problem hiding this comment.
Is this rename just to indicate that the parsed result isn't used? Just trying to learn idiomatic Rust
thebrandonlucas
approved these changes
Jun 4, 2024
thebrandonlucas
left a comment
thebrandonlucas
left a comment
Collaborator
There was a problem hiding this comment.
Tested and works. These logs are much more informative
DanGould
added a commit
that referenced
this pull request
Jun 4, 2024
#275 accidentally referenced an old config and failed CI. This fixes that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't reckon with async
--retryflows yet but sets the groundwork to do that properly, too.