Depend on bhttp =0.5.1 exactly - #302
Merged
Merged
Conversation
bhttp 0.5.2 broke MSRV 1.63.0 See: martinthomson/ohttp#69
spacebear21
approved these changes
Jun 25, 2024
spacebear21
left a comment
spacebear21
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for catching this, I was wondering about these latest failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bhttp 0.5.2 broke MSRV 1.63.0. I don't think just pinning in the README wouldn't fix this because 0.5.2 contains breaking changes.
See: martinthomson/ohttp#69
I noticed all of our CI jobs were breaking and I think this should fix it. I took this opportunity to bring
payjoin-diretory, the OHTTP Gateway, up to date with the same versions of ohttp and bhttp aspayjointoo.