Refactor ohttp keys - #317
Merged
Merged
Conversation
- use psbt.to_string() to get base64 - use base64::encode/decode_config with const configs
The `OhttpKeys` type is `Eq` so explicit impl can be replaced with a derive macro.
DanGould
force-pushed
the
refactor-ohttp-keys
branch
from
July 2, 2024 22:32
4ced3de to
b7cf5e8
Compare
Member
Author
|
I did a self review that re-ordered commits to put clippy first and change Error variants to exclude the word "Error" because it's redundant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
OhttpKeysso that #300 can just focus on semantics.DisplayandSerializeroles. OHTTP KeyConfigs encoding for serialization is well specified by the rfc. We're using string representations in URLs and configs just for Payjoin V2 which is a separate thing