Correctly set v=2 query parameter for v2 senders - #320
Merged
Conversation
Member
|
I'd like to see the commits squashed or have their order reversed so that we can reduce the number of known failing test states in our main branch. That way we can git bisect later and expect tests to pass |
DanGould
reviewed
Jul 9, 2024
spacebear21
marked this pull request as draft
July 10, 2024 17:55
spacebear21
marked this pull request as ready for review
July 11, 2024 19:01
Member
|
tACK but now we've a conflict since |
Closes payjoin#311. Set `v=2` in HTTP query string parameters when serializing v2 sender requests.
Collaborator
Author
|
Rebased |
Member
|
Does this make #144 feasible? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #311.
The modified test in the first commit fails without the changes in the second commit.