Skip to content

Expose test fixtures and fns at payjoin-test-utils - #425

Closed
DanGould wants to merge 2 commits into
payjoin:masterfrom
DanGould:test-utils
Closed

Expose test fixtures and fns at payjoin-test-utils#425
DanGould wants to merge 2 commits into
payjoin:masterfrom
DanGould:test-utils

Conversation

@DanGould

@DanGould DanGould commented Dec 3, 2024

Copy link
Copy Markdown
Member

This new crate also provides an opportunity to create downstream test fixtures in payjoin-ffi and language bindings downstream of it.

@coveralls

coveralls commented Dec 3, 2024

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 12146047684

Details

  • 53 of 57 (92.98%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 62.247%

Changes Missing Coverage Covered Lines Changed/Added Lines %
payjoin-test-utils/src/lib.rs 53 57 92.98%
Totals Coverage Status
Change from base Build 12132019366: 0.4%
Covered Lines: 2920
Relevant Lines: 4691

💛 - Coveralls

This new crate also provides an opportunity to create downstream test
fixtures in payjoin-ffi and language bindings downstream of it.
@DanGould DanGould added this to the Enable payjoin-ffi Testing milestone Dec 4, 2024
@DanGould
DanGould marked this pull request as ready for review December 31, 2024 03:47
@DanGould
DanGould requested a review from nothingmuch December 31, 2024 03:47
@DanGould
DanGould marked this pull request as draft December 31, 2024 03:47
@DanGould

Copy link
Copy Markdown
Member Author

whoops @nothingmuch this is NOT ready for review. Excuse the misclick

@DanGould

Copy link
Copy Markdown
Member Author

Closing in favor of #484

@DanGould DanGould closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants