Remove redundant clones#845
Merged
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 16014508825Details
💛 - Coveralls |
shinghim
marked this pull request as ready for review
July 9, 2025 01:22
nothingmuch
approved these changes
Jul 9, 2025
nothingmuch
left a comment
nothingmuch
left a comment
Contributor
There was a problem hiding this comment.
utACK, assuming this is clippy --fix's doing.
Feel free to ignore my suggestion
|
|
||
| pub fn from_id(db: Arc<Database>, id: SessionId) -> crate::db::Result<Self> { | ||
| Ok(Self { db: db.clone(), session_id: id }) | ||
| Ok(Self { db, session_id: id }) |
Contributor
There was a problem hiding this comment.
how is github so terrible
anyway this is pure bikeshedding but if the param is renamed from id to session_id this can be a little bit prettier
Suggested change
| Ok(Self { db, session_id: id }) | |
| Ok(Self { db, session_id }) |
arminsabouri
approved these changes
Jul 10, 2025
Contributor
There was a problem hiding this comment.
utACK a58d790
In the future, please put the command you ran in the commit message (if these fixes were automated)
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran
clippy::redundant_cloneand fixed the redundant clones