refactor: introduce payjoin_directory::Service#914
Merged
Conversation
nothingmuch
force-pushed
the
directory-service-struct
branch
from
August 2, 2025 23:52
de3b38f to
ca6fc8c
Compare
spacebear21
approved these changes
Aug 4, 2025
spacebear21
left a comment
Collaborator
There was a problem hiding this comment.
utACK, very nice refactor.
This is a preparatory change to avoid tight coupling to redis as a storage backend, and to enable ACME support by simplifying the listener logic. - implements hyper::Service trait - Arc<Mutex<ohttp::Server>> -> ohttp::Server - remove serve_payjoin_directory function - simplify and remove various listen helpers
nothingmuch
force-pushed
the
directory-service-struct
branch
from
August 4, 2025 14:02
ca6fc8c to
c173a25
Compare
Collaborator
Pull Request Test Coverage Report for Build 16725345224Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a preparatory change to avoid tight coupling to redis as a storage backend, and to enable ACME support by simplifying the listener logic.