Fix RPC error message regression in reqwest client#971
Merged
DanGould merged 1 commit intoAug 19, 2025
Conversation
The migration from bitcoincore-rpc to reqwest caused a regression where RPC error messages became generic "RPC request failed with status: 500" instead of showing which method failed and the actual error from Bitcoin Core. Changes: - Include RPC method name in error messages for better debugging - Extract and display actual error message from JSON-RPC error response - Replace generic HTTP status errors with descriptive Bitcoin Core messages - Add comprehensive tests with real Bitcoin Core integration Before: "RPC request failed with status: 500 Internal Server Error" After: "RPC 'walletcreatefundedpsbt' failed: Insufficient funds" Fixes payjoin#966
bc1cindy
force-pushed
the
fix/rpc-error-message-regression-966
branch
from
August 19, 2025 01:52
2399550 to
9e01d6b
Compare
Collaborator
Pull Request Test Coverage Report for Build 17057359385Details
💛 - Coveralls |
bc1cindy
marked this pull request as ready for review
August 19, 2025 01:57
This was referenced Aug 19, 2025
DanGould
approved these changes
Aug 19, 2025
DanGould
left a comment
DanGould
left a comment
Member
There was a problem hiding this comment.
Although I agree with @arminsabouri that this should be replaced with alpen's client soon this PR does address the regression. Much appreciated quick fix.
ACK 9e01d6b
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The migration from bitcoincore-rpc to reqwest caused a regression where RPC error messages became generic "RPC request failed with status: 500" instead of showing which method failed and the actual error from Bitcoin Core.
Changes:
Before: "RPC request failed with status: 500 Internal Server Error"
After: "RPC 'walletcreatefundedpsbt' failed: Insufficient funds"
Fixes #966
Pull Request Checklist
Please confirm the following before requesting review: