Replace String clones with references in CLI RPC methods#977
Merged
spacebear21 merged 1 commit intoAug 21, 2025
Merged
Conversation
- Change get_base_url() return type from String to &str - Use direct references instead of cloning self.url - Remove unnecessary Arc wrapper in PSBT v1 fallback processing
bc1cindy
force-pushed
the
optimize/cli-clone-reduction-#402
branch
from
August 20, 2025 15:36
059b114 to
29b5df5
Compare
bc1cindy
marked this pull request as ready for review
August 20, 2025 15:42
spacebear21
approved these changes
Aug 21, 2025
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #402
Pull Request Checklist
Please confirm the following before requesting review: