Simplify session id pj cli

[arminsabouri]

Both sender and receiver use the same i64 row id as their "session id". There is really no need for an enum representation.

Pull Request Checklist

Please confirm the following before requesting review:

• A human has reviewed every single line of this code before opening the PR (no auto-generated, unreviewed LLM/robot submissions).
• I have read CONTRIBUTING.md and rebased my branch to produce hygienic commits.

[DanGould]

Is there any chance the same database could be sending a payjoin to itself and clash on the same ID?

[arminsabouri]

Is there any chance the same database could be sending a payjoin to itself and clash on the same ID?

No, because sender and receiver have different sessions tables with different auto-incrementing ids.

[arminsabouri]

@DanGould the enum was an artifact of when both sender and receiver shared a sessions table
#873 (comment)

[DanGould]

concept ACK

[DanGould]

i find the visibility change odd bc payjoin-cli is not anyone's library dependency, but it's not a problem either.

edit: on second thought minimum visibility makes sense