Skip to content

Conversation

@GermanJablo
Copy link
Contributor

No description provided.

@AlessioGr
Copy link
Member

I would leave the explicit exports instead of using wildcards. Export wildcards often do not show up in TypeScript auto-import suggestions - I think they are often ignored for performance reasons.
Since switching to explicitly defined exports, this has improved

@GermanJablo
Copy link
Contributor Author

You're right.

This is the TypeScript issue that addresses that problem. There have been 3 related PRs to close or fix it [1] [2] [3]. Performance impact measurements had been made and found to be negligible.

However, something that was recently noted in the latest comments on the issue is that this solution limited the search to 10 entry points in the default VSCode configuration.

Issue #60704, tagged for the TypeScript 5.8.0 milestone, has been opened to review this issue.

I'm going to close this PR and wait for a resolution in #60704 to decide if this is worthwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants