fix: allow required fields with admin.condition in typescriptSchema#16800
Open
MurzNN wants to merge 1 commit into
Open
fix: allow required fields with admin.condition in typescriptSchema#16800MurzNN wants to merge 1 commit into
MurzNN wants to merge 1 commit into
Conversation
mrazauskas
reviewed
May 31, 2026
MurzNN
commented
May 31, 2026
Author
MurzNN
left a comment
There was a problem hiding this comment.
Simplified and cleaned up tests, review please.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Added support for marking fields as required in TypeScript schema generation when both
required: trueandadmin.conditionare defined. Updated the field requirement check inconfigToJSONSchema()to explicitly validate thefield.requiredproperty, and added comprehensive test coverage to validate the fix.Why?
Fields configured with
required: trueandadmin.conditionwere being incorrectly excluded from the required array during TypeScript type generation. This caused TypeScript to infer these fields as optional (field?) even though they were explicitly marked as required in the configuration, resulting in type mismatches and potential runtime errors.How?
Core Fix (configToJSONSchema.ts):
field.required === truecondition alongside existing checks (isRequiredandfieldSchema.required === true)admin.conditionto be included in the required array when they haverequired: trueTest Coverage (types):
configToJSONSchema()directly at runtime instead of reading pre-generated type filesRelated Issues
Fixes #16797