add ClientId to checksum#114
Merged
mschindler83 merged 1 commit intomasterfrom Mar 22, 2016
Merged
Conversation
cyrrill
added a commit
to cyrrill/paymill-php
that referenced
this pull request
Dec 24, 2015
Contributor
|
Hi @nikoloff , This PR happens to be incorrect, the field is actually named "client" not "clientId". I am actually implementing this feature for a product now, and have verified it functioning with the alternate name. I had merged your PR into #116 earlier, but have now corrected the variables and method names. Checked the Ruby client for reference before, unfortunately, it also has this issue. I will open a PR in the appropriate project. I would suggest to close this PR, and merge #116 instead. Thanks! |
This was referenced Dec 27, 2015
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.